[Hotfix 🔥 ] - 1.12.8 (#2628)

* 1.12.4 * Fix FAQ pages (#2621) * Fix FAQ pages * Fix content and const links Co-authored-by: fairlight <31534717+fairlighteth@users.noreply.github.com>
gnosis · Mar 31, 2022 · f34653d · f34653d
1 parent 9e25d14
commit f34653d
Show file tree

Hide file tree

Showing 4 changed files with 38 additions and 193 deletions.
diff --git a/src/custom/constants/index.ts b/src/custom/constants/index.ts
@@ -100,6 +100,14 @@ export const CODE_LINK = 'https://github.com/gnosis/gp-swap-ui'
 export const DISCORD_LINK = 'https://chat.cowswap.exchange'
 export const DUNE_DASHBOARD_LINK = 'https://duneanalytics.com/gnosis.protocol/Gnosis-Protocol-V2'
 export const TWITTER_LINK = 'https://twitter.com/mevprotection'
+export const GPAUDIT_LINK = 'https://github.com/gnosis/gp-v2-contracts/blob/main/audits/GnosisProtocolV2May2021.pdf'
+export const FLASHBOYS_LINK = 'https://arxiv.org/abs/1904.05234'
+export const COWWIKI_LINK = 'https://en.wikipedia.org/wiki/Coincidence_of_wants'
+export const GNOSIS_FORUM_ROADTODECENT_LINK = 'https://forum.gnosis.io/t/gpv2-road-to-decentralization/1245'
+
+// MEV Metrics from https://explore.flashbots.net/
+export const MEV_TOTAL = '606 Million'
+export const FLASHBOTS_LINK = 'https://explore.flashbots.net/'
 
 // 30 minutes
 export const GAS_PRICE_UPDATE_THRESHOLD = 30 * 60 * 1000

diff --git a/src/custom/pages/About/index.tsx b/src/custom/pages/About/index.tsx
@@ -2,6 +2,7 @@ import Page, { Title, Content, GdocsListStyle } from 'components/Page'
 import styled from 'styled-components/macro'
 import { Link } from 'react-router-dom'
 import { ExternalLink as ExternalLinkTheme } from 'theme'
+import { MEV_TOTAL, FLASHBOTS_LINK } from 'constants/index'
 
 // Assets
 import diagramIMG from 'assets/cow-swap/cowswap-diagram.png'
@@ -44,7 +45,7 @@ export default function About() {
         <p>
           Every time you and another trader each hold an asset the other wants, your trade is settled directly without
           using an AMM (Automated Market Maker) and therefore without incurring any slippage + fees. Only amounts that
-          can’t be settled with other CowSwap traders are sent to the underlying AMMs.
+          can&apos;t be settled with other CowSwap traders are sent to the underlying AMMs.
           <br />
           <br />
           This economic phenomenon is known as <b>Coincidence Of Wants (CoW)</b>.
@@ -63,7 +64,7 @@ export default function About() {
             <p>You sign a trade message which is submitted to CowSwap’s off-chain service</p>
           </li>
           <li>
-            <p>CowSwap’s off-chain service optimizes your trade’s execution by considering:</p>
+            <p>CowSwap&apos;s off-chain service optimizes your trade&apos;s execution by considering:</p>
             <ul>
               <li>
                 <p>Coincidence Of Wants</p>
@@ -91,9 +92,9 @@ export default function About() {
           <img src={mevIMG} alt="CowSwap - Maximum Extractable Value" />
         </p>
         <p>
-          Heard about Maximum Extractable Value yet? It’s scary. To date more than{' '}
-          <ExternalLink href="https://explore.flashbots.net/">USD 797M</ExternalLink> in value has been extracted from
-          users by bots frontrunning transactions, exploiting the slippage users allow in a trade.
+          Heard about Maximum Extractable Value yet? It&apos;s scary. To date more than{' '}
+          <ExternalLink href={FLASHBOTS_LINK}>USD {MEV_TOTAL}</ExternalLink> in value has been extracted from users by
+          bots frontrunning transactions, exploiting the slippage users allow in a trade.
           <br />
           <br />
           CowSwap is the first DEX Aggregator offering some protection against it: COWs enable tight slippages and can

diff --git a/src/custom/pages/Faq/GeneralFaq.tsx b/src/custom/pages/Faq/GeneralFaq.tsx
diff --git a/src/custom/pages/Faq/index.tsx b/src/custom/pages/Faq/index.tsx
@@ -1,6 +1,14 @@
 import { Link } from 'react-router-dom'
 
-import { DISCORD_LINK } from 'constants/index'
+import {
+  GPAUDIT_LINK,
+  COWWIKI_LINK,
+  GNOSIS_FORUM_ROADTODECENT_LINK,
+  FLASHBOYS_LINK,
+  DISCORD_LINK,
+  MEV_TOTAL,
+  FLASHBOTS_LINK,
+} from 'constants/index'
 import Page, { Content } from 'components/Page'
 import { ExternalLinkFaq, Wrapper, ButtonNav, FooterWrapper } from './styled'
 import { FaqMenu } from './Menu'
@@ -76,30 +84,26 @@ export default function Faq() {
 
           <p>
             Defined by Phil Daian et al. in the{' '}
-            <ExternalLinkFaq href="https://arxiv.org/abs/1904.05234">paper Flash Boys 2.0 </ExternalLinkFaq>, MEV is a
-            measure of the profit a miner (or validator, sequencer, etc.) can make through their ability to arbitrarily
-            include, exclude, or re-order transactions within the blocks they produce.
+            <ExternalLinkFaq href={FLASHBOYS_LINK}>paper Flash Boys 2.0 </ExternalLinkFaq>, MEV is a measure of the
+            profit a miner (or validator, sequencer, etc.) can make through their ability to arbitrarily include,
+            exclude, or re-order transactions within the blocks they produce.
           </p>
 
           <p>
-            Since January 2020 until now (July&#39;21), the total amount of value extracted by miners (etc.) on Ethereum
-            transactions has reached{' '}
-            <ExternalLinkFaq href="https://explore.flashbots.net/">
-              $ 796.8 Million, including successful and failed transactions.
-            </ExternalLinkFaq>
+            As of today the total amount of value extracted by miners (etc.) on Ethereum transactions has reached{' '}
+            <ExternalLinkFaq href={FLASHBOTS_LINK}>USD {MEV_TOTAL}</ExternalLinkFaq>, including successful and failed
+            transactions.
           </p>
 
           <h3 id="to-what-does-the-term-coincidence-of-wants-cows-refer">
             To what does the term Coincidence of Wants (CoWs) refer?
           </h3>
 
           <p>
-            <ExternalLinkFaq href="https://en.wikipedia.org/wiki/Coincidence_of_wants">
-              Coincidence of Wants (CoWs)
-            </ExternalLinkFaq>{' '}
-            can be explained as “an economic phenomenon where two parties each hold an item the other wants, so they
-            exchange these items directly.” CowSwap facilitates CoWs among traders and their orders through using batch
-            auctions as a core mechanism.
+            <ExternalLinkFaq href={COWWIKI_LINK}>Coincidence of Wants (CoWs)</ExternalLinkFaq> can be explained as “an
+            economic phenomenon where two parties each hold an item the other wants, so they exchange these items
+            directly.” CowSwap facilitates CoWs among traders and their orders through using batch auctions as a core
+            mechanism.
           </p>
 
           <p>
@@ -122,8 +126,8 @@ export default function Faq() {
           <p>
             CowSwap leverages batch auctions with uniform clearing prices for all trades in the same batch. Because of
             the uniform clearing price, there is no need for ordering the transactions within a single batch. Because
-            everyone receives the same price across assets it’s not possible for <b>any</b> value to be extracted by
-            placing transactions in a certain order. This prevents the primary strategy used in MEV.
+            everyone receives the same price across assets it&apos;s not possible for <b>any</b> value to be extracted
+            by placing transactions in a certain order. This prevents the primary strategy used in MEV.
           </p>
 
           <p>
@@ -158,10 +162,7 @@ export default function Faq() {
 
           <p>
             Finding the best settlement for orders is a challenging task, which very soon may have its own{' '}
-            <ExternalLinkFaq href="https://forum.gnosis.io/t/gpv2-road-to-decentralization/1245">
-              decentralized competition
-            </ExternalLinkFaq>
-            .
+            <ExternalLinkFaq href={GNOSIS_FORUM_ROADTODECENT_LINK}>decentralized competition</ExternalLinkFaq>.
           </p>
 
           <h3 id="is-cowswap-secure-to-use">Is CowSwap secure to use?</h3>
@@ -173,11 +174,8 @@ export default function Faq() {
 
           <p>
             With this upgrade, CowSwap evolves into its most stable, performant form: the code has been thoroughly and
-            carefully tested, peer-reviewed and fully{' '}
-            <ExternalLinkFaq href="https://github.com/gnosis/gp-v2-contracts/blob/main/audits/GnosisProtocolV2May2021.pdf">
-              audited
-            </ExternalLinkFaq>
-            . Whilst CowSwap has taken a major step forward in terms of security and stability, as with other crypto
+            carefully tested, peer-reviewed and fully <ExternalLinkFaq href={GPAUDIT_LINK}>audited</ExternalLinkFaq>.
+            Whilst CowSwap has taken a major step forward in terms of security and stability, as with other crypto
             protocols or dapps, your use is at your own risk.{' '}
             <strong>
               Please review our{' '}