Skip to content
This repository has been archived by the owner on Jun 24, 2022. It is now read-only.

[SENTRY] - Report order submission errors and update ignore list #2531

Merged
merged 5 commits into from
Mar 29, 2022

Conversation

W3stside
Copy link
Contributor

@W3stside W3stside commented Mar 9, 2022

Part of #2519

This PR does 2 things:

  1. Properly handle order submission logic and report sentry errors related to order submission similar to the way we handle quotes in [Sentry] Fix _handleQuoteError sentry reporting #2518
  2. Create an ignore errors list
  • ignores FeeExceedsFrom quote errors

Testing

  1. you'll need an .env.development.local or .env.local file with the sentry secrets. ping me if u need/want them
  2. open sentry and set environment to local
  3. try setting too low amount and getting fee exceeds from amount message - sentry will not report it
  4. try changing
    buyToken: toNativeBuyAddress(buyToken, chainId),
    to not use toNativeBuyAddress and instead use the same fn as the line 380 above it (except with buyToken) - submit a ERC20 sell // NATIVE buy order (e.g DAI/ETH on rinkeby) and you'll see the error reported

@W3stside W3stside marked this pull request as draft March 9, 2022 12:45
@github-actions
Copy link
Contributor

github-actions bot commented Mar 9, 2022

CLA Assistant Lite All Contributors have signed the CLA.

@github-actions
Copy link
Contributor

github-actions bot commented Mar 9, 2022

  • 🔭 GP Swap: CoW Protocol v2 Swap UI

@W3stside W3stside changed the title Sentry orders error [SENTRY] - Report order submission errors and update ignore list Mar 9, 2022
@W3stside W3stside requested review from anxolin and a team March 9, 2022 13:31
@W3stside W3stside marked this pull request as ready for review March 9, 2022 13:32
@W3stside W3stside requested a review from anxolin March 14, 2022 16:23
src/custom/api/gnosisProtocol/api.ts Outdated Show resolved Hide resolved
@W3stside W3stside changed the base branch from develop to hotfix/1.12.3 March 29, 2022 12:38
This was referenced Mar 29, 2022
@anxolin
Copy link
Contributor

anxolin commented Mar 29, 2022

Please, add in 1.12.4, because 1.12.3 is in production

@W3stside W3stside changed the base branch from hotfix/1.12.3 to hotfix/1.12.4 March 29, 2022 23:44
@W3stside W3stside merged commit 420873e into hotfix/1.12.4 Mar 29, 2022
@W3stside W3stside deleted the sentry-orders-error branch March 29, 2022 23:44
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants