This repository has been archived by the owner on Jun 24, 2022. It is now read-only.
Styled governance banner and inner card container. #2575
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Style vCOW swap cards. * Style vCOW swap cards. (#2565) * Add governance card banner. (#2566) * Add governance card banner. * Governance banner update styles. * Make question icon use dynamic dark/light mode colors. * Center content properly cross devices. * Dummy values. * Disable unused vars * Cleanup obsolete color
|
alfetopito
approved these changes
Mar 22, 2022
anxolin
approved these changes
Mar 23, 2022
| .stop1 { stop-color: ${({ theme }) => theme.white}} | ||
| .stop2 { stop-color: ${({ theme }) => theme.white}; stop-opacity: 0.8;} | ||
| .stop3 { stop-color: ${({ theme }) => theme.white}; stop-opacity: 0;} | ||
| .stop1 { |
There was a problem hiding this comment.
In principle, this banner seems too general to be in the Claim page. Maybe should be a component or something?
Since you are using it also in the profile.
Normally, if a component is defined in a page, is because is too specific for being in the components dir.
There was a problem hiding this comment.
Yes, agreed. Had the exact same thoughts. When working on it, I initially thought I could get away with simply re-using the same Component. But quickly realized I need more generic Card components, including a prop to define 'banner' like features. I plan to tackle this outside this PR and will create a ticket specifically for this.
|
Yeah let's merge this asap |
|
Looks nice! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary