Skip to content
This repository has been archived by the owner on Jun 24, 2022. It is now read-only.

Split refactor faq #2592

Merged
merged 19 commits into from
Mar 30, 2022
Merged

Split refactor faq #2592

merged 19 commits into from
Mar 30, 2022

Conversation

anxolin
Copy link
Contributor

@anxolin anxolin commented Mar 25, 2022 •
edited
Loading

Summary

Part of #2541

Split FAQ and refactor. FAQ is out of control :)
It's too big to read, and very unperformant. This PR breaks it down into sections.

image

image

Not included

🎨 Design not included. The PR is big enough. We can reiterate and make it nicer.

I discussed it with @fairlighteth , we can make iterarations:

  1. Basic one, just to add nice sections with maybe icons as the home for the FAQ. Also improve the back button, and the ToC.
  2. Try to show a side panel with the index of questions
  3. Try to show another side panel with the list of sections

Test

Check section to section, the content is equivalent to the original.
Please, don't include "style issues" in this PR. Its out of scope. Already big enough

avsavsavs and others added 5 commits March 14, 2022 07:21
@avsavsavs
Update FAQ to reflect Token Launch
4cc29de 
This PR pushes a new content section from lines 559 - 627 that addresses questions related to the token launch. I have tried format everything as good as I possibly know/can, apologies if it needs to be reworked. 

Questions are: 
562 - Does CowSwap Have a token? 
580 - Is there a proposal to make vCOW transferrable?
585 - what is the purspose of the COW tokens?
605 - what was the criteria for the token airdrop?
@lint-action
Fix code style issues with Prettier
feb5cd0
@anxolin
Fix building error
d9cd14d
@anxolin
Add space
bcec541
@avsavsavs
Update index.tsx
cb3ceb9
@anxolin anxolin requested review from avsavsavs and a team March 25, 2022 17:06
@anxolin anxolin changed the title Split refactpr faq Split refactor faq Mar 27, 2022
@anxolin anxolin mentioned this pull request Mar 27, 2022
Open
4 tasks
@anxolin anxolin marked this pull request as ready for review March 27, 2022 13:19
@anxolin anxolin mentioned this pull request Mar 27, 2022
Open
@github-actions
Copy link
Contributor

  • 🔭 GP Swap: CoW Protocol v2 Swap UI

@elena-zh
Copy link

Hey @anxolin , great changes!
Some my notes:

  1. We have this section at the bottom of the FAQ list.
    image

We may place it to the bottom of the main section. WDYT?
image

  1. It would be nice to change the date in the general - 'What is MEV and how much MEV has been extracted from users to date?' section
    image

  2. Protocol - Cancel an order --> 'this FAQ entry' does not navigate to anywhere. Should navigate to Trading - 'How can I cancel an order' section
    image

  3. My notes for the 'Token' section are still valid: Update FAQ to reflect Token Launch #2540 (comment) and Update FAQ to reflect Token Launch #2540 (comment)

  4. Trading- How does a trader submit a valid order in CowSwap? --> 'pre-sign' does not navigate to anywhere. Should navigate to 'Protocol' - 'What is pre-sign?' section
    image

Thanks!

@anxolin anxolin changed the base branch from develop to avsavsavs-patch-2 March 29, 2022 07:58
@anxolin anxolin changed the base branch from avsavsavs-patch-2 to develop March 29, 2022 10:48
@anxolin
Copy link
Contributor Author

anxolin commented Mar 29, 2022

@elena-zh addressed most of the issues.

For the vCOW address and listing COW, @avsavsavs might do the changes in another PR

@elena-zh
Copy link

elena-zh commented Mar 29, 2022 •
edited
Loading

Hey @anxolin !
Great changes!
Could you please fix these ones:

  1. Back button on the main page does not work. Maybe we could remove it?
    not working

  2. It would be great to change the year in the March'2021 to 2022
    march 22

  3. A bit incorrect navigation for the Protocol - Cancel an order --> 'this FAQ entry' : it should navigate to Trading - 'How can I cancel an order' section (not 'Protocol)
    cancel

  4. NEW! I think it would be great to navigate a user fron this link on the Terms and Conditions page top the main FAQ page (/#/faq) . Currently, it navigates to the 'General' section
    image

  5. Again, question with the footer: should we place it to the bottom of every subsection? Currently, it is displayed only under 'Affiliate Program' subsection, and now on the General page
    image

  6. Tiny one: could we please fix this typo Typo in the FAQ 'Are Smart Contract wallets supported?' section #2067 in this PR?

@elena-zh elena-zh mentioned this pull request Mar 29, 2022
Open
@anxolin
Copy link
Contributor Author

anxolin commented Mar 29, 2022

  1. done
  2. done
  3. done
  4. done
  5. I added the (ugly) footer in all sections, right?
  6. done

@elena-zh
Copy link

Hey @anxolin , seems that the last changes were not deployed due to the failed build

elena-zh
elena-zh approved these changes Mar 30, 2022
View reviewed changes
Copy link

@elena-zh elena-zh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@anxolin , changes LGTM now. Thank you!

@anxolin anxolin merged commit e3df73a into develop Mar 30, 2022
nenadV91 pushed a commit that referenced this pull request Mar 30, 2022
@anxolin @avsavsavs
@lint-action @nenadV91
Split refactor faq (#2592)
66a94a8 
* Update FAQ to reflect Token Launch

This PR pushes a new content section from lines 559 - 627 that addresses questions related to the token launch. I have tried format everything as good as I possibly know/can, apologies if it needs to be reworked.

Questions are:
562 - Does CowSwap Have a token?
580 - Is there a proposal to make vCOW transferrable?
585 - what is the purspose of the COW tokens?
605 - what was the criteria for the token airdrop?

* Fix code style issues with Prettier

* Fix building error

* Add space

* Update index.tsx

* Fix code style issues with Prettier

* Split and refactor FAQ

* Fix links

* Add footer

* Add footer to index too

* Update metrics

* Fix internal links

* Hide back in home

* Link to FAQ

* Correct year

* Fix typo. Fixes #2067

Co-authored-by: Alex V <80408352+avsavsavs@users.noreply.github.com>
Co-authored-by: Lint Action <lint-action@samuelmeuli.com>
nenadV91 added a commit that referenced this pull request Mar 30, 2022
@nenadV91 @anxolin
@avsavsavs @lint-action @fairlighteth @alfetopito @W3stside
[Hotfix 🔥 ] - 1.12.4 - rc.2 (#2615)
f0d0050 
* Split refactor faq (#2592)

* Update FAQ to reflect Token Launch

This PR pushes a new content section from lines 559 - 627 that addresses questions related to the token launch. I have tried format everything as good as I possibly know/can, apologies if it needs to be reworked.

Questions are:
562 - Does CowSwap Have a token?
580 - Is there a proposal to make vCOW transferrable?
585 - what is the purspose of the COW tokens?
605 - what was the criteria for the token airdrop?

* Fix code style issues with Prettier

* Fix building error

* Add space

* Update index.tsx

* Fix code style issues with Prettier

* Split and refactor FAQ

* Fix links

* Add footer

* Add footer to index too

* Update metrics

* Fix internal links

* Hide back in home

* Link to FAQ

* Correct year

* Fix typo. Fixes #2067

Co-authored-by: Alex V <80408352+avsavsavs@users.noreply.github.com>
Co-authored-by: Lint Action <lint-action@samuelmeuli.com>

* Re-style FAQ menu. (#2611)

* Update FAQ to reflect Token Launch

This PR pushes a new content section from lines 559 - 627 that addresses questions related to the token launch. I have tried format everything as good as I possibly know/can, apologies if it needs to be reworked. 

Questions are: 
562 - Does CowSwap Have a token? 
580 - Is there a proposal to make vCOW transferrable?
585 - what is the purspose of the COW tokens?
605 - what was the criteria for the token airdrop?

* Fix code style issues with Prettier

* Fix building error

* Add space

* Profile page: Add vCOW swap feature cards (#2564)

* Style vCOW swap cards.

* Style vCOW swap cards. (#2565)

* Add governance card banner. (#2566)

* Add governance card banner.

* Governance banner update styles.

* Make question icon use dynamic dark/light mode colors.

* Center content properly cross devices.

* Dummy values.

* Disable unused vars

* Cleanup obsolete color

* Moving custom components to mod file to avoid circular dependencies/lazy loading issues (#2580)

Co-authored-by: Leandro <leandro.boscariol@gnosis.io>

* Remove isClaiming flag (#2586)

* Remove lint warn (#2587)

* Update index.tsx

* Fix code style issues with Prettier

* Split and refactor FAQ

* Update FAQ to reflect Token Launch (#2540)

* Update FAQ to reflect Token Launch

This PR pushes a new content section from lines 559 - 627 that addresses questions related to the token launch. I have tried format everything as good as I possibly know/can, apologies if it needs to be reworked. 

Questions are: 
562 - Does CowSwap Have a token? 
580 - Is there a proposal to make vCOW transferrable?
585 - what is the purspose of the COW tokens?
605 - what was the criteria for the token airdrop?

* Fix code style issues with Prettier

* Fix building error

* Add space

* Update index.tsx

* Fix code style issues with Prettier

* Add punctuantions

Co-authored-by: Lint Action <lint-action@samuelmeuli.com>
Co-authored-by: Anxo Rodriguez <anxolin@gmail.com>

* Fix links

* Add footer

* Add footer to index too

* Update metrics

* Fix internal links

* Hide back in home

* Link to FAQ

* Correct year

* Fix typo. Fixes #2067

* Re-style FAQ menu.

* Title styles.

* Cleanup console.log

* Fix merge and style back to top + misc.

* Text updates.

* Fix code style issues with Prettier

* Remove click events.

* Fix lint issue.

* Remove is claim enabled

Co-authored-by: Alex V <80408352+avsavsavs@users.noreply.github.com>
Co-authored-by: Lint Action <lint-action@samuelmeuli.com>
Co-authored-by: Anxo Rodriguez <anxolin@gmail.com>
Co-authored-by: Leandro Boscariol <alfetopito@users.noreply.github.com>
Co-authored-by: Leandro <leandro.boscariol@gnosis.io>
Co-authored-by: w3stside <david.sato64@gmail.com>

Co-authored-by: Anxo Rodriguez <anxolin@gmail.com>
Co-authored-by: Alex V <80408352+avsavsavs@users.noreply.github.com>
Co-authored-by: Lint Action <lint-action@samuelmeuli.com>
Co-authored-by: fairlight <31534717+fairlighteth@users.noreply.github.com>
Co-authored-by: Leandro Boscariol <alfetopito@users.noreply.github.com>
Co-authored-by: Leandro <leandro.boscariol@gnosis.io>
Co-authored-by: w3stside <david.sato64@gmail.com>
@nenadV91 nenadV91 mentioned this pull request Mar 31, 2022
Merged
This was referenced Apr 1, 2022
Closed
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@elena-zh elena-zh elena-zh approved these changes

@avsavsavs avsavsavs Awaiting requested review from avsavsavs

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@anxolin @elena-zh @avsavsavs @lint-action