This repository has been archived by the owner on Apr 4, 2022. It is now read-only.
Fix format price #155
Merged
Fix format price #155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
W3stside
approved these changes
Jun 23, 2020
anxolin
reviewed
Jun 23, 2020
There was a problem hiding this comment.
My concern is that I'm not sure how this affected the original issue that trigger this PR
How the inverse of 0.1 can be 1 instead of 10
We have a private thread about this
https://gnosisinc.slack.com/archives/GPBEB8PKP/p1592928322034700
Apparently there's a relationship, but still unclear to me
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
formatPricewas rounding numbers like0.99999wrong.It was failing to increment integer, resulting in
0.1000Issue in gnosis/gp-v1-ui#1129