Add mocked ethereum call implementation #108
Conversation
nlordell
force-pushed
the
eth-call-implementation
branch
from
e2bb0d9 to
e8abf5f
Compare
| @@ -35,7 +35,7 @@ export class Abi { | |||
| } | |||
|
|
|||
| private readArray<T>(ptr: Pointer, reader: (value: Pointer) => T): T[] | null { | |||
| if (ptr === null) { | |||
| if (ptr === 0) { | |||
There was a problem hiding this comment.
This should be caught by the typechecker (cf open issue), maybe we can use a lint rule for now to catch these: https://github.com/microsoft/TypeScript/issues/11920https://palantir.github.io/tslint/rules/strict-type-predicates/
There was a problem hiding this comment.
We're using ESLint-TypeScript (since, from what I understand, tslint is deprecated) and I couldn't find the rule at first sight: https://github.com/typescript-eslint/typescript-eslint/blob/master/packages/eslint-plugin/README.md#extension-rules
There was a problem hiding this comment.
I think @typescript-eslint/no-unnecessary-condition would have caught this (https://github.com/typescript-eslint/typescript-eslint/blob/master/packages/eslint-plugin/docs/rules/no-unnecessary-condition.md).
| describe('onTokenListing', function () { | ||
| it('creates a token', async () => { | ||
| const mappings = await Mappings.load() | ||
| mappings.setCallHandler((call) => { |
There was a problem hiding this comment.
Cool, I assume in then long term we can just pass in the Abis and perform the calls automatically?
There was a problem hiding this comment.
Correct! The idea is to have something like we have for the events and entities, except for events. Ultimately, I think all of this should be auto-generated based on the subgraph.yaml definition.
nlordell
force-pushed
the
token-listing-handler
branch
from
0dd5a70 to
dc72b4b
Compare
nlordell
force-pushed
the
eth-call-implementation
branch
from
e8abf5f to
fca044f
Compare
This PR adds an implementation for the last used The Graph host import 🎉 -
eth_calls. With it comes unit tests for the new token listing handler code.Test Plan
Added new unit tests to run on CI 🤖