relax null values check (#1248)

Co-authored-by: Leandro Boscariol <alfetopito@users.noreply.github.com>
gnosis · Jul 21, 2020 · 8e4fa12 · 8e4fa12
1 parent 01a9a98
commit 8e4fa12
Showing 1 changed file with 2 additions and 10 deletions.
diff --git a/src/components/TradeWidget/index.tsx b/src/components/TradeWidget/index.tsx
@@ -868,15 +868,7 @@ const TradeWidget: React.FC = () => {
     const cachedSellToken = getToken('symbol', sellToken.symbol, tokens)
 
     // Do not let potential null values through
-    if (
-      !buyAmount ||
-      buyAmount.isZero() ||
-      !sellAmount ||
-      sellAmount.isZero() ||
-      !cachedBuyToken ||
-      !cachedSellToken ||
-      !networkId
-    ) {
+    if (!buyAmount || buyAmount.isZero() || !sellAmount || sellAmount.isZero() || !cachedBuyToken || !cachedSellToken) {
       logDebug(
         `Preventing null values on submit: 
         buyAmount:${buyAmount}, sellAmount:${sellAmount}, 
@@ -894,7 +886,7 @@ const TradeWidget: React.FC = () => {
       sellToken: cachedSellToken,
       buyToken: cachedBuyToken,
     }
-    if (isConnected && userAddress) {
+    if (isConnected && userAddress && networkId) {
       await _placeOrder({
         ...orderParams,
         networkId,