Skip to content
This repository has been archived by the owner on Jan 15, 2021. It is now read-only.

Use Staging Price API Endpoint for development and PR branches #1121

Closed
Velenir opened this issue Jun 19, 2020 · 0 comments · Fixed by #1183
Closed

Use Staging Price API Endpoint for development and PR branches #1121

Velenir opened this issue Jun 19, 2020 · 0 comments · Fixed by #1183
Milestone

Comments

@Velenir
Copy link
Contributor

Velenir commented Jun 19, 2020

Link to a different price estimation service based on deployment

  • By default: Use the production ones
  • PR + Develop: Use their staging

For example. It could be implemented in travis by having a logic depending on the branch:

if (
   branch <> master OR
   is not a tag
) {
   BACEND_URL = 1234
}

Not sure what is the cleanest way to do it, but travis allows to set rules by branch. Also that the in the shell script, it exposes information as environemt variable to build this conditional behaviour.

@Velenir Velenir added this to the Sprint 16 milestone Jun 19, 2020
@anxolin anxolin changed the title Price estimation estimation changes Use Staging Price API Endpoint for development and PR branches Jun 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants