This repository has been archived by the owner on Jan 15, 2021. It is now read-only.
Estimator url prod/dev #1183
Merged
Estimator url prod/dev #1183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Travis automatic deployment: |
anxolin
reviewed
Jul 1, 2020
.travis.yml
Outdated
| @@ -11,6 +11,8 @@ before_install: | |||
| # Needed to deploy pull request and releases | |||
| - sudo apt-get -y install python-pip python-dev | |||
| - pip install awscli --upgrade --user | |||
| # use production url for price estimator on master or tagged | |||
| - export PRICE_ESTIMATOR_URL=$([[ $TRAVIS_BRANCH = "master" || $TRAVIS_TAG != "" ]] && echo "production" || echo "develop") | |||
There was a problem hiding this comment.
Sorry it was not in the description. But can we use production one ALSO in the release/* and hotfix/* branches?
We want those ones AS CLOSE AS POSSIBLE as production
anxolin
approved these changes
Jul 2, 2020
| - export PRICE_ESTIMATOR_URL=$([[ | ||
| $TRAVIS_BRANCH = master || \ | ||
| $TRAVIS_BRANCH = release/* || \ | ||
| $TRAVIS_BRANCH = hotfix/* || \ |
There was a problem hiding this comment.
Great! I guess to make sure it works, we need to merge the thing :)
We now have an open hotfix, it's a great moment to get this thing merged 👍
alfetopito
approved these changes
Jul 2, 2020
| @@ -11,6 +11,13 @@ before_install: | |||
| # Needed to deploy pull request and releases | |||
| - sudo apt-get -y install python-pip python-dev | |||
| - pip install awscli --upgrade --user | |||
| # use production url for price estimator on master or tagged | |||
| - export PRICE_ESTIMATOR_URL=$([[ | |||
There was a problem hiding this comment.
That's fancy! I was thinking something way simpler, but hey, glad you are doing this :)
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Differentiate between different estimators based on master branch/tag release
Fixes #1121