This repository has been archived by the owner on Jan 15, 2021. It is now read-only.
Update/dex js 0.4.0 #1051
Merged
Update/dex js 0.4.0 #1051
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* MaximumSlippage: create comp 1. dumb for now * Tooltip size prop * text * moved MaximumSlippage to own file 1. minor css changes * const: slippage map and default slip * PriceSlippage reducer & actions * Price: move MaximumSlippage state inside 1. MaximumSlippage remains dumb 2. added slippage label next to price title for clarity * MaximumSlippage: passed state setters / CSS 1. passed custom slippage setters from parent containers 2. css fixes * const: fixed exports + added new const 1. BigNumber ONE & ONE_HUNDRED exports * usePriceEstimation: added slippage price calc * just use index as key * css for dark mode * remove slippage from app because :( * commented in useful code for if we reinstantiate * move price checking function to utils/price * usePriceEstimation: removed price slippage code 1. also removed reducer code for slippage
|
Travis automatic deployment: |
Velenir
approved these changes
May 25, 2020
alfetopito
approved these changes
May 25, 2020
anxolin
approved these changes
May 25, 2020
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Had to update types on contracts (as Dima warned)
I will update
smartFormatinto this PR so don't merge plz