This repository has been archived by the owner on Jan 15, 2021. It is now read-only.
reverse market computation #1127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Travis automatic deployment: |
W3stside
added a commit
that referenced
this pull request
Jun 19, 2020
* conputeMarketProp: always return string * filter orders by market * remove Market type * make filterTradesAndOrderFnFactory and new filter fns 1. filterTradesFn 2. filterOrdersFn 3. pass to useDataFilter 4. Orders: make work for both different filters * remove computeMarketProp * computeMarketProp accepts args to create inverse market 1. allow inverse markets to be searched on demand * empty string separator * reverse market computation (#1127) * reverse market computation * Trades: invert price (#1128)
W3stside
added a commit
that referenced
this pull request
Jun 19, 2020
* moved common fns to utils 1. filter fns to utils/filter 2. computeMarketProp to utils/display * move DetailedPendingOrder into ExchangeAPI 1. create Market interface which is extended by DetailedAuctionElement, DetailedPendingOrder + Trades * moved types and imported, moved fns out of OrdersWidget into utils * derive market prop in useTrades for later filtering 1. use in TradesWidget * fixed moved type * Filter /Orders by market (#1119) * conputeMarketProp: always return string * filter orders by market * remove Market type * make filterTradesAndOrderFnFactory and new filter fns 1. filterTradesFn 2. filterOrdersFn 3. pass to useDataFilter 4. Orders: make work for both different filters * remove computeMarketProp * computeMarketProp accepts args to create inverse market 1. allow inverse markets to be searched on demand * empty string separator * reverse market computation (#1127) * reverse market computation * Trades: invert price (#1128)
alfetopito
pushed a commit
that referenced
this pull request
Jun 24, 2020
* CardTable CSS 1. fix issue with left - right alignment 2. pass left alignment as default, right as custom to Balances 3. min-height and no padding for forced equal header height 4. css cleanup (formatting, lint) 5. less padding trades header * Card default css 1. format css for readability 2. better padding * add isTab prop to set smaller columns dimensions * fixed lowBalance format * 1102/filter fills trades (#1116) * moved common fns to utils 1. filter fns to utils/filter 2. computeMarketProp to utils/display * move DetailedPendingOrder into ExchangeAPI 1. create Market interface which is extended by DetailedAuctionElement, DetailedPendingOrder + Trades * moved types and imported, moved fns out of OrdersWidget into utils * derive market prop in useTrades for later filtering 1. use in TradesWidget * fixed moved type * Filter /Orders by market (#1119) * conputeMarketProp: always return string * filter orders by market * remove Market type * make filterTradesAndOrderFnFactory and new filter fns 1. filterTradesFn 2. filterOrdersFn 3. pass to useDataFilter 4. Orders: make work for both different filters * remove computeMarketProp * computeMarketProp accepts args to create inverse market 1. allow inverse markets to be searched on demand * empty string separator * reverse market computation (#1127) * reverse market computation * Trades: invert price (#1128) * CardRowDrawer classname 1. dont use styled component as class 2. fix padding * Update src/components/Layout/Card/Card.tsx Co-authored-by: Velenir <Velenir@users.noreply.github.com> * make CardTable/Widget fit better 1. Balances page: less cluttering, better wrapping format 2. make wrap/unwrap buttons thinner * Orders: better responsive design Co-authored-by: Velenir <Velenir@users.noreply.github.com>
alfetopito
added a commit
that referenced
this pull request
Jun 24, 2020
* Adding breathing room to trades table * 1029/styling take 3 mobile opt (#1098) * extrapolate common CardWidget into new component * add correct data labels to TradeRow * Added CardWidgetWrapper to TradesWidget * address der uebernit, ja wohl * Extracting InnerTradesWidget component for reusability * Fitting `Fills` tab into TradeWidget * Combine limit price and fill price columns * Combine amount and received columns * Adding some space when using double headers on same column * Added some padding to the left of Fills table * Renamed columns Amount=>Sold and Received=>Bought * Move Fills tab to second position * 1029.2/david style take (#1112) * CardTable CSS 1. fix issue with left - right alignment 2. pass left alignment as default, right as custom to Balances 3. min-height and no padding for forced equal header height 4. css cleanup (formatting, lint) 5. less padding trades header * Card default css 1. format css for readability 2. better padding * add isTab prop to set smaller columns dimensions * fixed lowBalance format * 1102/filter fills trades (#1116) * moved common fns to utils 1. filter fns to utils/filter 2. computeMarketProp to utils/display * move DetailedPendingOrder into ExchangeAPI 1. create Market interface which is extended by DetailedAuctionElement, DetailedPendingOrder + Trades * moved types and imported, moved fns out of OrdersWidget into utils * derive market prop in useTrades for later filtering 1. use in TradesWidget * fixed moved type * Filter /Orders by market (#1119) * conputeMarketProp: always return string * filter orders by market * remove Market type * make filterTradesAndOrderFnFactory and new filter fns 1. filterTradesFn 2. filterOrdersFn 3. pass to useDataFilter 4. Orders: make work for both different filters * remove computeMarketProp * computeMarketProp accepts args to create inverse market 1. allow inverse markets to be searched on demand * empty string separator * reverse market computation (#1127) * reverse market computation * Trades: invert price (#1128) * CardRowDrawer classname 1. dont use styled component as class 2. fix padding * Update src/components/Layout/Card/Card.tsx Co-authored-by: Velenir <Velenir@users.noreply.github.com> * make CardTable/Widget fit better 1. Balances page: less cluttering, better wrapping format 2. make wrap/unwrap buttons thinner * Orders: better responsive design Co-authored-by: Velenir <Velenir@users.noreply.github.com> Co-authored-by: Leandro Boscariol <leandro.boscariol@gnosis.io> Co-authored-by: David <david.sato64@gmail.com> Co-authored-by: Velenir <Velenir@users.noreply.github.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverses the market computation for filtering: WETH/DAI is now filtered by DAI/WETH etc