This repository has been archived by the owner on Jan 15, 2021. It is now read-only.
Trade Page: Do not expire by default #1146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anxolin
requested review from
Velenir,
alfetopito and
W3stside
and removed request for
Velenir
|
Travis automatic deployment: |
Velenir
approved these changes
Jun 23, 2020
W3stside
approved these changes
Jun 23, 2020
anxolin
added a commit
that referenced
this pull request
Jun 23, 2020
* comment out PriceInputBox for direct price * display market as X BUY per SELL * fix styling for different token symbols * fix receiveAmount not updating on priceInverse change * SELL per BUY * allow to swap between prices * Updating how we calculate whether a token is enabled. Instead of a hard value of max uint128, we now check whether allowance is >= 10**(token.decimals + 12) * fix OrderValidityBox style * 1.0.2 * Trade Page: Do not expire by default (#1146) * By default do not expire * Fix issue with the expire never * Fix build error * Wallet connect bridge (#1145) * Add new config for wallet connect bridge * Document wallet connect config * Use config for wallet connect * Capitalize title * Add env message * 1.0.3 Co-authored-by: Velenir <velenir@gmail.com> Co-authored-by: Leandro Boscariol <leandro.boscariol@gnosis.io>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default params fo the trade sets "Never" as the default expiration date