This repository has been archived by the owner on Jan 15, 2021. It is now read-only.
Using transaction time instead of batch time for trades date #1156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Travis automatic deployment: |
Velenir
approved these changes
Jun 25, 2020
W3stside
approved these changes
Jun 26, 2020
alfetopito
force-pushed
the
adjust-trades-match-time
branch
from
7c62786 to
cd74aee
Compare
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem
Date displayed for a trade was based on batch time, which is the start of the 5min interval.
It's misleading though, since in fact the trade happens up to minute 4 of the batch.
So when the trade is actually detected, it' shows as having happened 4min+ ago.
With this change, the time displayed is the transaction timestamp of when the solver executed the trade.