-
Notifications
You must be signed in to change notification settings - Fork 41
Conversation
Travis automatic deployment: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like it, quite the big change here 👏
Besides the minor comments bellow, it worked for me.
I only tested the infuraId though.
One question about that.
I first changed the infuraId, then connected my safe.
I went back and removed my custom infuraId.
Then I was prompted to connect the wallet again.
Is that expected?
Did you remove id by clearing input and clicking Apply? |
Yup
Yep. Then is working as expected. |
Co-authored-by: Leandro Boscariol <alfetopito@users.noreply.github.com>
Co-authored-by: Leandro Boscariol <alfetopito@users.noreply.github.com>
Unpopular opinion: make inputs expand on focus OR stack as column on smaller size and + add a larger margin between the inputs and the also less |
Honestly, I'd rather not do too much with the styling 😉 , on account of this here being a secret settings page. Inputs already stack vertically when on Mobile size. Or I don't quite understand what you mean. |
Seemingly works
/settings
But needs testing
https://pr1160--dexreact.review.gnosisdev.com/settings