Skip to content
This repository has been archived by the owner on Jan 15, 2021. It is now read-only.

Settings page #1160

Merged
merged 30 commits into from
Jul 1, 2020
Merged

Settings page #1160

merged 30 commits into from
Jul 1, 2020

Conversation

Velenir
Copy link
Contributor

@Velenir Velenir commented Jun 26, 2020

Seemingly works
/settings
But needs testing

https://pr1160--dexreact.review.gnosisdev.com/settings

localhost_8080_settings (1)

@ghost
Copy link

ghost commented Jun 26, 2020

Travis automatic deployment:
https://pr1160--dexreact.review.gnosisdev.com

Copy link
Contributor

@alfetopito alfetopito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like it, quite the big change here 👏

Besides the minor comments bellow, it worked for me.
I only tested the infuraId though.

One question about that.
I first changed the infuraId, then connected my safe.
I went back and removed my custom infuraId.
Then I was prompted to connect the wallet again.
Is that expected?

src/App.tsx Outdated Show resolved Hide resolved
src/components/Settings/WalletConnect.tsx Outdated Show resolved Hide resolved
src/pages/Settings.tsx Show resolved Hide resolved
src/utils/walletconnectOptions.ts Outdated Show resolved Hide resolved
@Velenir
Copy link
Contributor Author

Velenir commented Jun 26, 2020

Did you remove id by clearing input and clicking Apply?
It should reprompt when you have ongoing WC connection and change WC settings, for you to re-establish connection with new settings. And then redirect to home.
If no ongoing WC then no reprompt.
If you had connection with custom id and reset to default id then it should reprompt.
Was that it?

@alfetopito
Copy link
Contributor

Did you remove id by clearing input and clicking Apply?

Yup

It should reprompt when you have ongoing WC connection and change WC settings, for you to re-establish connection with new settings. And then redirect to home.
If no ongoing WC then no reprompt.
If you had connection with custom id and reset to default id then it should reprompt.
Was that it?

Yep. Then is working as expected.

@W3stside
Copy link
Contributor

Unpopular opinion: make inputs expand on focus OR stack as column on smaller size and + add a larger margin between the inputs and the OR text and align the titles (InfuraId etc) horizontally with the inputs :)

also less box-shadow - is that the var(--box-shadow) amount? seems hefty but anyways less would be kew

@Velenir
Copy link
Contributor Author

Velenir commented Jun 29, 2020

Unpopular opinion: make inputs expand on focus OR stack as column on smaller size and + add a larger margin between the inputs and the OR text and align the titles (InfuraId etc) horizontally with the inputs :)

Honestly, I'd rather not do too much with the styling 😉 , on account of this here being a secret settings page.
But anyone is welcome to make it prettier 😉 😉 .

Inputs already stack vertically when on Mobile size. Or I don't quite understand what you mean.

@Velenir Velenir merged commit 88de89f into develop Jul 1, 2020
@Velenir Velenir deleted the fix_autoconnect branch July 1, 2020 09:38
@alfetopito alfetopito mentioned this pull request Jul 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants