Skip to content
This repository has been archived by the owner on Jan 15, 2021. It is now read-only.

Fix filter orders delete #1162

Merged
merged 5 commits into from
Jul 1, 2020
Merged

Fix filter orders delete #1162

merged 5 commits into from
Jul 1, 2020

Conversation

Velenir
Copy link
Contributor

@Velenir Velenir commented Jun 29, 2020

Fix #1107

Now checking delete/cancel all only checks currently displayed orders
And clears previous selection if any.

@ghost
Copy link

ghost commented Jun 29, 2020

Travis automatic deployment:
https://pr1162--dexreact.review.gnosisdev.com

Copy link
Contributor

@alfetopito alfetopito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

// copy full state
Object.keys(curr).forEach(tab => (state[tab] = curr[tab]))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You know, I was always wondering at the complexity of this code Vs doing what you did. Personally was too scared/lazy to actually do it. Absolute mad man

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Velenir Velenir merged commit 52c0ca0 into develop Jul 1, 2020
@Velenir Velenir deleted the fix_filter_orders_delete branch July 1, 2020 10:42
@alfetopito alfetopito mentioned this pull request Jul 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Filtering Orders + delete orders bad UX
3 participants