Skip to content
This repository has been archived by the owner on Jan 15, 2021. It is now read-only.

disable wrapEther on disconnect #1208

Merged
merged 2 commits into from
Jul 8, 2020
Merged

disable wrapEther on disconnect #1208

merged 2 commits into from
Jul 8, 2020

Conversation

W3stside
Copy link
Contributor

@W3stside W3stside commented Jul 8, 2020

Closes #1193

Disconnect wallet and check button isnt there

@ghost
Copy link

ghost commented Jul 8, 2020

Travis automatic deployment:
https://pr1208--dexreact.review.gnosisdev.com

@anxolin
Copy link
Contributor

anxolin commented Jul 8, 2020

Perfect!

Not related to this PR, but can we just add a tooltip here?
image

See how the other links have one:

image

image

One suggestion:
"Deposit tokens into the Exchange Balance so it can be used for trading"

@anxolin
Copy link
Contributor

anxolin commented Jul 8, 2020

Also, ubernit!

I think this is not aligned:
image

@anxolin
Copy link
Contributor

anxolin commented Jul 8, 2020

Maybe the above is even solved by the tooltip? Cause otherwise I don't see the difference in the two links

@W3stside W3stside merged commit 4a6c6c0 into develop Jul 8, 2020
@W3stside W3stside deleted the 1193/wrap-ether-bug branch July 8, 2020 15:30
@alfetopito alfetopito mentioned this pull request Jul 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrap ether with disconnected wallet
3 participants