-
Notifications
You must be signed in to change notification settings - Fork 41
Conversation
Travis automatic deployment: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Guess what :)
Prices are the other way around. The normal price should be BUY/SELL, the "inverse" should be the other. As a reference, you can check what you are selling, in this case we sell DAI for USDC. So normal price should be quoted in DAI.
I'm good as it is, I'm equally good removing one of the price units. The reason to add it, is to see it more clear if the price is to bad (by a mistake), so u don't need to reason about quote/base tokens in the market. One unit for the two prices is enough imo
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2f05967
to
e65f506
Compare
e65f506
to
f5c1579
Compare
Update July 10
Addressed comments:
liquidity
orders now have theFill %
andTotal Order Amount
filled with `unlimited.These entries have examples of all changes and it's easy to find verify the price/inverse price and units.
Part of #1206
Addressing points 4 to 9
Before:
After:
Easier to see if you copy and paste onto a spreadsheet. Screenshot is waaaay to long.