Skip to content
This repository has been archived by the owner on Jan 15, 2021. It is now read-only.

Change GetPriceResponse type to correspond to dex-price-estimator #1224

Merged
merged 2 commits into from
Jul 14, 2020
Merged

Change GetPriceResponse type to correspond to dex-price-estimator #1224

merged 2 commits into from
Jul 14, 2020

Conversation

Velenir
Copy link
Contributor

@Velenir Velenir commented Jul 13, 2020

Closes #1221

@Velenir Velenir requested review from alfetopito and W3stside July 13, 2020 13:35
@ghost
Copy link

ghost commented Jul 13, 2020

Travis automatic deployment:
https://pr1224--dexreact.review.gnosisdev.com

alfetopito
alfetopito approved these changes Jul 13, 2020
View reviewed changes
Copy link
Contributor

@alfetopito alfetopito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Question: should this go into 1.1 or 1.2?

@Velenir
Copy link
Contributor Author

Velenir commented Jul 14, 2020

Question: should this go into 1.1 or 1.2?

Doesn't matter.

@Velenir Velenir merged commit 80f7706 into develop Jul 14, 2020
@Velenir Velenir deleted the chnage_GetPriceResponse branch July 14, 2020 14:35
@alfetopito alfetopito mentioned this pull request Jul 16, 2020
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@W3stside W3stside W3stside approved these changes

@alfetopito alfetopito alfetopito approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Price Estimator changes token id type in response from string to number
3 participants
@Velenir @alfetopito @W3stside