This repository has been archived by the owner on Jan 15, 2021. It is now read-only.
Decreasing the amount of token required to consider token enabled #1230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Travis automatic deployment: |
Velenir
approved these changes
Jul 16, 2020
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1229
This issue as been previously addressed on #1147 when a token used uint128 for allowance.
This time, the token uses uint96.
This change reduces the minimum amount required to consider a token enabled.
Using the COMP token as example, that has 18 decimal places, the user now will have to deposit over 29 billion COMP before an allowance refresh is required:
To test, add COMP token (
0xc00e94Cb662C3520282E6f5717214004A7f26888) to your mainnet wallet and enabled it.On latest mesa.eth.link after refresh the page, the enable button will be shown again.
On this PR, it won't.