Skip to content
This repository has been archived by the owner on Jan 15, 2021. It is now read-only.

Fix liquidity orders on rinkeby #1238

Merged
merged 2 commits into from
Jul 17, 2020
Merged

Fix liquidity orders on rinkeby #1238

merged 2 commits into from
Jul 17, 2020

Conversation

Velenir
Copy link
Contributor

@Velenir Velenir commented Jul 17, 2020

The issue happens because:

  1. Page load
  2. No connection => default networkId = 1
  3. selectedTokensMap is filled with tokens from network 1
  4. Connection to rinkeby established
  5. Tokens updated
  6. But selectedTokensMap not refilled

This is a quick fix, but let's switch to addresses instead of symbols soonish.
Having addresses in LIQUIDITY_TOKEN_LIST and that list differentiating by network would have made this issue more obvious (cause there would not have been a match for wrong address on the right network)

Closes #1235

@Velenir Velenir requested review from alfetopito and W3stside July 17, 2020 14:17
@ghost
Copy link

ghost commented Jul 17, 2020

Travis automatic deployment:
https://pr1238--dexreact.review.gnosisdev.com

Copy link
Contributor

@alfetopito alfetopito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working like a charm!

Copy link
Contributor

@W3stside W3stside left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good fix!

@alfetopito alfetopito changed the base branch from release/1.1.0 to develop July 17, 2020 17:25
@alfetopito alfetopito merged commit c029283 into develop Jul 17, 2020
@alfetopito alfetopito deleted the fix_rinkeby_liq_orders branch July 17, 2020 17:32
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't place liquidity orders
3 participants