Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use BLS aggregate signatures for validator registry #53

Merged
merged 3 commits into from
Dec 17, 2024

Conversation

Marchhill
Copy link
Contributor

@Marchhill Marchhill commented Oct 25, 2024

This PR makes it much faster and cheaper to submit validator registrations.

To register n consecutive validators with consecutive indices would previously take n submissions of 142 bytes. With this PR we can register all n with a single 142 byte submission. This has several advantages:

  • Much faster to submit
  • Won't cause rate limiting due to spamming an endpoint with many submissions
  • Cheaper gas costs
  • Less signatures need to be verified by validators / keypers

Copy link
Contributor

@konradkonrad konradkonrad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a pretty clever and elegant way to make this change, without needing too much other changes. Looks good!

It would be great to exchange some test vectors for the aggregate signature format before moving forward.

shutter/low-level.md Show resolved Hide resolved
Copy link
Contributor

@konradkonrad konradkonrad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - we have it implemented like this and works in testing.

@konradkonrad
Copy link
Contributor

@Marchhill looks like I don't have Approval rights in this repos. But from our side this is good to go!

@dapplion
Copy link
Member

@konradkonrad please throw an approve on related PRs to you even if you don't have perms

@dapplion dapplion merged commit 2bf1a84 into gnosischain:master Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants