Feat: Migration to Zodiac Core and Task Improvements in Bridge Module #24
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This Pull Request focuses on the integration of the new Zodiac Core package across the Bridge module. The key objective is to replace the previous Gnosis Zodiac dependencies with the newly established Zodiac Core to enhance modularity and reduce tightly coupled dependencies.
Key Changes:
Migration to Zodiac Core:
@gnosis.pm/zodiac
with the new@gnosis-guild/zodiac-core
.AMBModule.sol
,TestFactory.sol
, and other contracts to reflect these changes.Task Improvements:
deploy:mastercopies
: Deploys all mastercopies.deploy:mastercopy --contract-version <version>
: Deploys a specific version of a mastercopy.verify:mastercopies
: Verifies all mastercopies.verify:mastercopy --contract-version <version>
: Verifies a specific version of a mastercopy.Configuration Updates:
hardhat.config.ts
to import new task files and include new network configurations like Sepolia.Package and Dependency Upgrades:
@gnosis-guild/zodiac-core
and removed the old Zodiac dependencies.Test Suite Updates:
AMBModule.spec.ts
to ensure they work with the refactored contract logic.Solution:
The solution involved refactoring existing contracts and tasks to use Zodiac Core. This makes the system more modular and reduces the risk of introducing bugs during future updates. The new approach also enhances the clarity of the codebase, making it easier for developers to work with.