Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Migration to Zodiac Core and Task Improvements in Bridge Module #24

Merged
merged 8 commits into from
Aug 27, 2024

Conversation

juliopavila
Copy link
Contributor

@juliopavila juliopavila commented Aug 9, 2024

Description:

This Pull Request focuses on the integration of the new Zodiac Core package across the Bridge module. The key objective is to replace the previous Gnosis Zodiac dependencies with the newly established Zodiac Core to enhance modularity and reduce tightly coupled dependencies.

Key Changes:

  1. Migration to Zodiac Core:

    • Replaced all previous imports from @gnosis.pm/zodiac with the new @gnosis-guild/zodiac-core.
    • Updated AMBModule.sol, TestFactory.sol, and other contracts to reflect these changes.
  2. Task Improvements:

    • Added new tasks for deploying and verifying mastercopies, leveraging the modular approach from Zodiac Core:
      • deploy:mastercopies: Deploys all mastercopies.
      • deploy:mastercopy --contract-version <version>: Deploys a specific version of a mastercopy.
      • verify:mastercopies: Verifies all mastercopies.
      • verify:mastercopy --contract-version <version>: Verifies a specific version of a mastercopy.
    • Removed outdated task files and reorganized task scripts for clarity and maintainability.
  3. Configuration Updates:

    • Updated the Hardhat configuration to include the necessary setups for the new tasks and dependencies.
    • Modified hardhat.config.ts to import new task files and include new network configurations like Sepolia.
  4. Package and Dependency Upgrades:

    • Upgraded various npm dependencies to their latest versions, including Hardhat plugins and TypeScript.
    • Introduced the latest version of @gnosis-guild/zodiac-core and removed the old Zodiac dependencies.
  5. Test Suite Updates:

    • Modified existing tests to be compatible with the new Zodiac Core structure.
    • Updated assertions in AMBModule.spec.ts to ensure they work with the refactored contract logic.

Solution:

The solution involved refactoring existing contracts and tasks to use Zodiac Core. This makes the system more modular and reduces the risk of introducing bugs during future updates. The new approach also enhances the clarity of the codebase, making it easier for developers to work with.

@juliopavila juliopavila requested a review from cristovaoth August 9, 2024 00:49
@juliopavila juliopavila changed the title feat: use zodiac core and upgrade dependencies [WIP] - feat: use zodiac core and upgrade dependencies Aug 9, 2024
@juliopavila juliopavila added the enhancement New feature or request label Aug 9, 2024
contracts/AMBModule.sol Outdated Show resolved Hide resolved
@juliopavila juliopavila requested a review from samepant August 26, 2024 21:57
@juliopavila juliopavila changed the title [WIP] - feat: use zodiac core and upgrade dependencies Feat: Migration to Zodiac Core and Task Improvements in Bridge Module Aug 26, 2024
@samepant samepant merged commit 9ff8ed2 into main Aug 27, 2024
1 check passed
@samepant samepant deleted the use-zodiac-core branch August 27, 2024 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants