-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: Implemente zodiac-core
package, upgrade dependencies and migrate to ethers v6
#75
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…2.0 into mastercopies.json file
feat: improve hardhat task
juliopavila
changed the title
Use zodiac-core
Feat: Implemente Aug 26, 2024
zodiac-core
package, upgrade dependencies and migrate to ethers v6
samepant
approved these changes
Aug 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR introduces significant improvements using the new zodiac-core package for deploying and verifying mastercopies. The changes include the following:
Key Changes:
Task Separation:
deploy:mastercopies
- Deploys the latest version of all mastercopies.deploy:mastercopy --contract-version <version>
- Deploys a specific version of the mastercopies across all contracts that have that version.verify:mastercopies
- Verifies the latest version of all mastercopies.verify:mastercopy --contract-version <version>
- Verifies a specific version of the mastercopies across all contracts that have that version.Task Removal:
setup.ts
file, as its functionality has been replaced by the new, more modular task scripts.Enhanced Functionality:
Version Handling:
--contract-version
flag is now optional. If not provided, the tasks default to using the latest version of the contracts.--contract-version
flag is provided, the tasks specifically target and deploy or verify the version specified across all applicable contracts.Deployment Logic:
--contract-version
parameter is set. If not, it defaults to the latest version. If a version is specified, the script deploys that version across all contracts with matching versions on the selected network.Verification Logic:
Example Usage:
Testing and Verification:
Deploy all mastercopies
Deploy the latest version
Deploy specific version
** Verify all mastercopies **
** Verify latest mastercopy **
Verify specific version