New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Emit events in setter functions #75

Closed

6 tasks

asgeir-s opened this issue Nov 29, 2022 · 1 comment · Fixed by #76

Closed

6 tasks

Emit events in setter functions #75

asgeir-s opened this issue Nov 29, 2022 · 1 comment · Fixed by #76

Labels

Contributor

asgeir-s commented Nov 29, 2022

In the currently deployed version, it's hard for off-chain systems (analytics, UI, etc.) to keep track of changes to a Reality Module's parameters.

This could be solved by emitting events on setter functions:

asgeir-s added the enhancement label

Member

auryn-macmillan commented Nov 29, 2022

Yeah, I think this is valid.
I also think that we could add these events without invalidating the previous audits.
Thoughts, @nginnever ?

auryn-macmillan mentioned this issue

Merged

3 tasks

auryn-macmillan closed this as completed in #76

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment