add events #76
Merged
add events #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 3649813124
💛 - Coveralls |
cristovaoth
approved these changes
Dec 8, 2022
asgeir-s
reviewed
Dec 9, 2022
There was a problem hiding this comment.
Nice, it will be much easier to view the interactions off-chain now.
Added some comments.
Also, is it possible to add an event for when a proposal is marked as invalid? So that we know we do not have to watch for that proposalId anymore and can mark it as invalid (even if it has not expired).
|
Ok, I've added the extra events. Given that I added extra functions, these changes are going to need to be audited. That being the case, I've also bumped the solidity version to 0.8.6 and added custom errors. I'll hold off on merging this until it has been audited. |
|
Are there any other changes that we should put in while we're at it? Perhaps it's worthwhile also adding these changes? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds events and custom errors to the Reality contracts, along with some other housekeeping (bumps solidity version, additional set functions, updates tests, fixed some comments, adds hardhat-size-contracts).
Closes #75
Closes #74
Closes #69
Audit checklist: