Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chore: Tasks and documentation update #53

Merged
merged 3 commits into from
Sep 12, 2021
Merged

Chore: Tasks and documentation update #53

merged 3 commits into from
Sep 12, 2021

Conversation

cbrzn
Copy link
Collaborator

@cbrzn cbrzn commented Sep 11, 2021

Changes proposed:

  • factorySetup task was removed, now we added a proxied flag in the setup task in order to deploy the contract through factory proxy
  • Documentation updated with target attribute
  • Setup task now supports target attribute
  • Documentation and tasks updated with RealtioV3 ETH and ERC20 contracts

@github-actions
Copy link
Contributor

CLA Assistant Lite All Contributors have signed the CLA.

@cbrzn cbrzn force-pushed the chore/scripts-and-documentation-update branch from 1282124 to eaddfd6 Compare September 11, 2021 18:07
@coveralls
Copy link

coveralls commented Sep 11, 2021 •
edited
Loading

Pull Request Test Coverage Report for Build 1224844803

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%
Totals Coverage Status
Change from base Build 1219756363: 0.0%
Covered Lines: 96
Relevant Lines: 96
💛 - Coveralls

auryn-macmillan
auryn-macmillan approved these changes Sep 12, 2021
View reviewed changes
Copy link
Member

@auryn-macmillan auryn-macmillan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@auryn-macmillan auryn-macmillan merged commit 5497649 into main Sep 12, 2021
@auryn-macmillan auryn-macmillan deleted the chore/scripts-and-documentation-update branch September 12, 2021 01:36
@github-actions github-actions bot locked and limited conversation to collaborators Sep 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@auryn-macmillan auryn-macmillan auryn-macmillan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cbrzn @coveralls @auryn-macmillan