refactor: add arbitrator address to constructor #58
+61
−43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA Assistant Lite All Contributors have signed the CLA. |
|
I have read the CLA Document and I hereby sign the CLA |
|
recheckcla |
|
recheckcla |
auryn-macmillan
approved these changes
Sep 28, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the arbitrator address of the Reality Module can only be set by calling
setArbitratorafter initialization, while the initialization itself assigns the oracle address (e.g. Realitio) as the arbitrator. Even if the user decides that no arbitrator should be used, it is an important parameter in Realitio's configuration. This PR is intended to allow the arbitrator address to be set during construction/initialization.I also think that the UI should allow users to set the arbitrator in a similar fashion to Realitio's UI.