Fix initcode is not always array and prevent incompatible hardhat and ethers verions #102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Array check fails
To make sure that an incompatible version is not used.
Bothe for consistency and so that we can use deployModuleFactory from other project that import the zodiac package
cristovaoth
requested changes
Dec 30, 2022
From a suggestion from @cristovaoth
@cristovaoth suggestion
cristovaoth
previously approved these changes
Dec 30, 2022
@cristovaoth suggestion
cristovaoth
approved these changes
Dec 30, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix bug: we assumed that the init code is always an array, but it can also be a string.
Fix: Make sure that compatible versions of hardhat and ethers are used.
Fix: Use preexisting initCode and salt for deploying the ModuleFactory.