Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[🔥A1] Modifier.sol Transactions with EIP-712 and EIP-1271 Signature Authentication #137

Merged
merged 41 commits into from
Oct 27, 2023
Merged

[🔥A1] Modifier.sol Transactions with EIP-712 and EIP-1271 Signature Authentication #137

merged 41 commits into from
Oct 27, 2023

Conversation

cristovaoth
Copy link
Contributor

@cristovaoth cristovaoth commented Sep 28, 2023 •
edited
Loading

This PR introduces a mechanism for executing Modifier transactions using EIP-712 and EIP-1271 signatures.

Rather than directly dispatching a transaction to a Modifier (msg.sender), an authorized account can now generate a signature for the call. A relayer can then transmit the transaction by appending the generated signature to calldata.

Note: Existing modules can inherit from this version of Modifier.sol and incorporate the new auth transparently, without code changes.

@cristovaoth cristovaoth marked this pull request as draft September 28, 2023 01:09
@cristovaoth cristovaoth changed the title Eip 712 signatures Modifier Authentication using EIP712 sigs Sep 28, 2023
@cristovaoth cristovaoth changed the title Modifier Authentication using EIP712 sigs Enhancing Modifier Transactions with EIP-712 Signature Authentication Sep 28, 2023
@cristovaoth cristovaoth changed the title Enhancing Modifier Transactions with EIP-712 Signature Authentication Modifier.sol Transactions with EIP-712 Signature Authentication Sep 28, 2023
@cristovaoth cristovaoth marked this pull request as ready for review September 28, 2023 09:58
@auryn-macmillan auryn-macmillan changed the title Modifier.sol Transactions with EIP-712 Signature Authentication [🔥A1] Modifier.sol Transactions with EIP-712 Signature Authentication Sep 28, 2023
Barichek
Barichek reviewed Sep 29, 2023
View reviewed changes
contracts/signature/Eip712Signature.sol Outdated Show resolved Hide resolved
contracts/signature/Eip712Signature.sol Outdated Show resolved Hide resolved
@github-actions
Copy link

github-actions bot commented Sep 29, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 6651472581

  • 68 of 69 (98.55%) changed or added relevant lines in 6 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+6.0%) to 99.02%
Changes Missing Coverage Covered Lines Changed/Added Lines %
contracts/core/Modifier.sol 13 14 92.86%
Totals Coverage Status
Change from base Build 6350639740: 6.0%
Covered Lines: 121
Relevant Lines: 122
💛 - Coveralls

@cristovaoth cristovaoth changed the title [🔥A1] Modifier.sol Transactions with EIP-712 Signature Authentication [🔥A1] Modifier.sol Transactions with EIP-712 and EIP-1271 Signature Authentication Sep 30, 2023
@cristovaoth
Adjust comments
d05f894
@cristovaoth
Introduce GuardableModule and GuardableModifier - this makes Module a…
7c6c8ef 
…nd Modifier leaner by default
@cristovaoth
GuardableModifier tests
446cd08
@cristovaoth
Bumping OpenZeppeling for bytecode optimized base classes
cc0e322
@cristovaoth
remove import
f098f7d
@cristovaoth
Mark exec functions as virtual for Guardable*
2cf6cda
@cristovaoth
Prettier
d2a122d
@cristovaoth
Make execTransactionFromModule virtual
022394c
@cristovaoth
Add comment to Modifier.sol
fc032b7
@cristovaoth
Break down Modifier authorization logic in reusable parts
7960593
@cristovaoth
Add failing tests
9093ce3
@cristovaoth
Changing the base SignatureChecker to work with user proposed salt, i…
9aaae1b 
…nstead of self managed nonce
@cristovaoth
Introduce execution tracking into Modifier.sol based on executed and …
ea645eb 
…invalidated hashes
@cristovaoth
Rename auxiliary function
dd9e84c
@cristovaoth
Moving the newly introducedd errors into ExecutionTracker
908adeb
@cristovaoth
Fully cover guard with tests
cd40d32
@cristovaoth
Make sentOrSigned by an internal helper function for Modifiers
91d32ee
@cristovaoth
Make moduleTxSignedBy return always the hash, even when no signer fou…
c4211a4 
…nd recovered
@cristovaoth
Consolidate hash tracking into one mapping
41f16eb
@cristovaoth
Ensure contract specific signature is sliced correctly
9c1306e
@cristovaoth
Simplify splitSignature, and pull up logic that assembles the isValid…
637dcf1 
…ContractSignature call
@cristovaoth
Add test for contract specific signature empty
64971c5
@cristovaoth
Remove aux variable
9f65e4d
@cristovaoth
Consistently return hash from moduleTxSignedBy()
267725a
@cristovaoth cristovaoth merged commit 94dc31a into master Oct 27, 2023
2 checks passed
@cristovaoth cristovaoth deleted the eip-712-signatures branch October 27, 2023 17:40
@github-actions github-actions bot locked and limited conversation to collaborators Oct 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@auryn-macmillan auryn-macmillan auryn-macmillan approved these changes

@Barichek Barichek Awaiting requested review from Barichek

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cristovaoth @auryn-macmillan @Barichek