Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve monitoring scripts #89

Merged
merged 2 commits into from
Nov 25, 2022
Merged

Improve monitoring scripts #89

merged 2 commits into from
Nov 25, 2022

Conversation

juliopavila
Copy link
Collaborator

@juliopavila juliopavila commented Nov 24, 2022 •
edited
Loading

This PR contains

  • Add the proper packages
  • Improve the createSentinelForModuleFactory method
  • Generate on_new_question_from_module using typescript
  • Generate readFileAndReplace, packageCode inside the utils file

@juliopavila juliopavila requested a review from asgeir-s November 24, 2022 21:26
@github-actions
Copy link

github-actions bot commented Nov 24, 2022 •
edited
Loading

CLA Assistant Lite bot:
Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.

I have read the CLA Document and I hereby sign the CLA

1 out of 2 committers have signed the CLA.
✅ @manboy-eth
❌ @juliopavila
You can retrigger this bot by commenting recheck in this Pull Request

asgeir-s
asgeir-s approved these changes Nov 25, 2022
View reviewed changes
Copy link
Contributor

@asgeir-s asgeir-s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just updated it a bit so it represents our current needs ✌️

@asgeir-s asgeir-s merged commit 059d826 into monitoring-setup-scripts Nov 25, 2022
@asgeir-s asgeir-s deleted the monitoring-setup-scripts-improvements branch November 25, 2022 08:57
@github-actions github-actions bot locked and limited conversation to collaborators Nov 25, 2022
@juliopavila
Copy link
Collaborator Author

I have read the CLA Document and I hereby sign the CLA

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@asgeir-s asgeir-s asgeir-s approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@juliopavila @asgeir-s