-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: configuration file of rules #91
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for adding the feature you suggested recently. I believe this will become a very important functionality for linter.
However, I've left some comments that could be improved. Please check them when you have a chance. thanks!
@0xtekgrinder Anyway, most of all, it looks good to me. Thanks for the big contribution. 👍 |
fixes #82
This PR adds a few things:
This refactor a lot of code so I am really open to any criticism as I don't believe it is the best way to implement these features.
I also added a data field in the rules to be used later on.