user: Render placeholder in UserAvatar for unknown user

gnprice · Nov 10, 2023 · da3a572 · da3a572
1 parent a230134
commit da3a572
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/src/common/UserAvatar.js b/src/common/UserAvatar.js
@@ -12,7 +12,7 @@ import { IconUserBlank } from './Icons';
 import { ThemeContext } from '../styles';
 
 type Props = $ReadOnly<{|
-  avatarUrl: AvatarURL,
+  avatarUrl: AvatarURL | null,
   size: number,
   isMuted?: boolean,
   children?: Node,
@@ -46,7 +46,7 @@ function UserAvatar(props: Props): Node {
   const auth = useSelector(state => getAuth(state));
 
   let userImage;
-  if (isMuted) {
+  if (isMuted || !avatarUrl) {
     userImage = <IconUserBlank size={size} color={color} style={iconStyle} />;
   } else {
     userImage = (

diff --git a/src/common/UserAvatarWithPresence.js b/src/common/UserAvatarWithPresence.js
@@ -40,7 +40,7 @@ export default function UserAvatarWithPresence(props: Props): Node {
 
   if (!user) {
     logging.warn("UserAvatarWithPresence: couldn't find user for ID", { userId });
-    return null;
+    return <UserAvatar avatarUrl={null} size={size} isMuted onPress={undefined} />;
   }
 
   return (