Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for octfile support #181

Open
cbm755 opened this issue Mar 19, 2018 · 2 comments
Open

Add tests for octfile support #181

cbm755 opened this issue Mar 19, 2018 · 2 comments

Comments

@cbm755
Copy link
Collaborator

cbm755 commented Mar 19, 2018

See #179 (comment)

I'm not sure we want to depend on mkoctfile to install our package but I certainly don't mind if development depends on it...

  • At least Fedora (and probably others) runs tests as part of packaging. Our content is currently noarch but because of tests, we'd have compiled objects.
  • one option is to not have it as part of our formal tests.
  • In practice, probably only matters that CI runs it (as @catch22 highlighted).

@mtmiller: thoughts on this? Is it reasonable to compile the .oct code at run time, from within Octave?

@mtmiller
Copy link
Collaborator

With my developer hat on, yes, if you have no problem with maintaining some extra C++ functions for CI testing, that sounds good to me. I suppose this could be a separate make target?

With my Debian packaging hat on, I think it would be nice to at least make it possible for distributions to run these tests if they want to. IOW it's all there in the release if they want it, with an optional flag or a separate make target name or something.

Is it reasonable to compile the .oct code at run time, from within Octave?

Not sure what you are distinguishing against here. If you mean is it ok that the .oct files aren't compiled until the tests are invoked, that sounds fine to me. They are test data, there's no need to structure them as if they were normal functions to be built and installed as part of the package.

@cbm755
Copy link
Collaborator Author

cbm755 commented Mar 19, 2018

If you mean is it ok that the .oct files aren't compiled until the tests are invoked, that sounds fine to me.

Yes, this.

cbm755 added a commit that referenced this issue Mar 19, 2018
@cbm755 cbm755 mentioned this issue Feb 26, 2019
11 tasks
@cbm755 cbm755 added this to the 1.0.0 milestone Mar 23, 2019
cbm755 added a commit that referenced this issue Jan 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants