remove blocking eventloop. #1882
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As widget_event , handleevent() and xmanager are written now, there should be only one eventlist, not two (this old feature always worried me). xmanager simply blocks on widget_event by default and the loop does not give back the line command until the blocking widgest is closed. A progressbar using a timer has been introduced in test_widgets: its behaviour is now 100% compatible with IDL ( try to create 2 test_widgets, one non blocking and the next blocking: same behaviour, even the error returned when the blocking widget is closed before the non-blocking one is also observed in IDL)
|
did not find any adverse problem in test_widgets, ATV, look, Graffer etc. Merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As widget_event , handleevent() and xmanager are written now, there should be only one eventlist, not two (this old feature always worried me). xmanager simply blocks on widget_event by default and the loop does not give back the line command until the blocking widgest is closed. A progressbar using a timer has been introduced in test_widgets: its behaviour is now 100% compatible with IDL ( try to create 2 test_widgets, one non blocking and the next blocking: same behaviour, even the error returned when the blocking widget is closed before the non-blocking one is also observed in IDL)