Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bluecat: skip deploy #2230

Merged
merged 1 commit into from
Jul 20, 2024
Merged

bluecat: skip deploy #2230

merged 1 commit into from
Jul 20, 2024

Conversation

ldez
Copy link
Member

@ldez ldez commented Jul 19, 2024

Fixes #2229

@ldez ldez mentioned this pull request Jul 19, 2024
Closed
3 tasks
@ldez ldez added the state/need-user-tests Need users to test functionality label Jul 19, 2024
@ldez ldez marked this pull request as ready for review July 19, 2024 18:32
@ldez ldez requested a review from dmke July 19, 2024 18:32
@ldez ldez added this to the v4.18 milestone Jul 19, 2024
@ldez ldez added enhancement and removed state/need-user-tests Need users to test functionality labels Jul 19, 2024
dmke
dmke approved these changes Jul 20, 2024
View reviewed changes
Copy link
Member

@dmke dmke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ldez ldez merged commit 9873b9b into go-acme:master Jul 20, 2024
4 checks passed
@ldez ldez deleted the feat/bluecat-deploy branch July 20, 2024 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmke dmke dmke approved these changes

Assignees
No one assigned
Labels
area/dnsprovider enhancement
Milestone
v4.18
Development

Successfully merging this pull request may close these issues.

BlueCat cleanup fails so no cert created
2 participants
@ldez @dmke