-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add DNS provider for Lima-City #2248
Conversation
Ping @ldez have a bit of trouble here steps:
and got
please let me know if i did something wrong because i dont see it xD |
also double checked the api key and its registered as dns.admin, domain.admin |
Do you check out my branch? git switch feat/lima-city |
oh wow yeah i kinda never realized that taking the clone url on github doesnt actually give you the branch youre checking out in the browser... |
|
idk what this error to clarify the values that i redacted
hope that helps |
I fixed the problem, can you try again? |
|
whats the deal with error presenting token? |
I fixed the problem, can you try again? |
almost got it xD
so what i checked in addition. but as i understand should be why idk tho... |
btw thank you for showing me that 3x ` creates code blocks |
I think it's a propagation issue, can you try to add LIMACITY_PROPAGATION_TIMEOUT=120 LIMACITY_API_KEY=<api-key> ./dist/lego -m my@email.com --dns limacity -d *.example.com -d example.com -s https://acme-staging-v02.api.letsencrypt.org/directory run |
Wait there is also a type error, I will fix that. |
FYI I wrote the implementation only based on the API doc, which contains no explanation of what exactly is an endpoint, some endpoints are missing, and the schema can be wrong. For example, the JSONSchema inside the API documentation says that: {
"required": ["errors", "status"],
"type": "object",
"properties": {
"status": {
"type": "string",
"example": "invalid_resource",
"isRequired": true
},
"errors": {
"type": "object",
"description": "An object containing all validation errors. The parameter name is the key, the value is an array of strings",
"example": {"name": ["muss ausgefüllt werden"]},
"isRequired": true
}
}
}
From your logs: {"status":400,"error":"Bad Request"}
Another example is the endpoint to get records: {
"required": ["records"],
"type": "object",
"properties": {
"records": {
"type": "array",
"items": {
"required": ["content", "id", "name", "subdomain", "ttl", "type"],
"type": "object",
"properties": {
"id": {"type": "string", "example": "1234"},
"name": {"type": "string", "example": "example.com"},
"subdomain": {"type": "string"},
"type": {"type": "string", "example": "NS"},
"content": {"type": "string", "example": "ns1.lima-city.de"},
"ttl": {"type": "integer", "example": 3600}
}
}
}
}
}
From your logs: {"records":[.................,{"id":2******,"name":"example.com","subdomain":false,"type":"TXT","content":"\"w**************\"","priority":null,"ttl":3600},{"id":2*****,"name":"example.com","subdomain":false,"type":"TXT","content":"\"1*****************\"","priority":null,"ttl":3600}]}
I think that Lima City should improve its API and its documentation. |
fully agree xD |
thank you for doing all that work |
I fixed all the ID types, let's go try again 😄 |
Another example, with the endpoint to add records: {
"required": ["nameserver_record"],
"type": "object",
"properties": {
"nameserver_record": {
"required": ["content", "name", "subdomain", "ttl", "type"],
"type": "object",
"properties": {
"name": {"type": "string", "example": "example.com"},
"type": {"type": "string", "example": "NS"},
"content": {"type": "string", "example": "ns1.lima-city.de"},
"ttl": {"type": "integer", "example": 3600},
"priority": {"type": "string", "example": "10"}
}
}
}
}
I don't know if So I'm sorry to be forced to do this try-and-fix cycle. |
WTF, from your logs:
|
yes it looks like its a boolean testing didnt work rn either. i still get entries at lima-city registered under |
in addition to that i tested editing the entry to _acme-challenge.example.com and kept the value the same. all while the script was in its wait interval but still no luck |
I tried something to fix the subdomain, but I don't know if it's the right approach 🤷 |
still no certs ... but we have a partial success... i now get txt-records with logs to come |
|
so i guess subdomain is no bool... |
We made it!!! It was a long journey, but a great victory 🎉 |
thank you so much for your patience! it was great work and a great first experience for me too "working" on some open-source project. please feel free to reach out in the future if needed! Thank you! |
I will not hesitate. |
Wont be the last! sent something your way ;) Have a nice evening |
@dmke haha nice! i didnt expect this to happen this late. thank you so very much too! |
make build rm -rf .lego LIMACITY_API_KEY=yyyy \ ./dist/lego -m your@email.com --dns limacity -d *.example.com -d example.com -s https://acme-staging-v02.api.letsencrypt.org/directory run
go mod tidy
Ping @feroxib, can you run the command (with your domain, email, and credentials)?
-> #2248
Closes #2247