Export function to doisplay packet content #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnweldon
approved these changes
Apr 3, 2023
This patch split PrintPacket in two parts, the second part is DescribePacket a function which describe the packet content without recursion, indentation, nor jump line. The goal is providing a simple way logging detailled protocol errors on speciafic output (other than io.Stdout)
|
That's done, I think the commit will pass CI. |
|
Sorry, can you try pushing a new commit to this so that the updated actions can run? (If that doesn't work we can just merge this, and try to fix the actions later) |
|
Hi, I just push in force, and the PR is up to date with my change. It seems the linter fails because it panics (itself). I attach a screenshot.
|
|
Thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch split PrintPacket in two parts, the second part is DescribePacket a function which describe the packet content without recursion, indentation, nor jump line.
The goal is providing a simple way logging detailled protocol errors on speciafic output (other than io.Stdout)
Obviously this patch doesn't break the API or the behaviour of the project.