Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add OID Implementation #43

Merged
merged 5 commits into from
Apr 30, 2024
Merged

Add OID Implementation #43

merged 5 commits into from
Apr 30, 2024

Conversation

s00500
Copy link
Contributor

@s00500 s00500 commented Apr 29, 2024

Adds an ObjectIdentifier implementation, stole some of the functions from the go standard library, if you are interested I can also clean it up a bit better :-)

Greetings

@s00500
Add object identifier encode decode
39ed11e 
Signed-off-by: Lukas Bachschwell <lukas@lbsfilm.at>
@s00500
bump go version to support go work
6b4fcff 
Signed-off-by: Lukas Bachschwell <lukas@lbsfilm.at>
@s00500
remove log
8d5f2a5 
Signed-off-by: Lukas Bachschwell <lukas@lbsfilm.at>
johnweldon
johnweldon requested changes Apr 29, 2024
View reviewed changes
Copy link
Contributor

@johnweldon johnweldon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this PR

I like the idea and direction of this.

If you could add some tests and consider the comments I've left we can consider cleaning this up and merging it.

ber.go Outdated Show resolved Hide resolved
go.mod Outdated Show resolved Hide resolved
go.mod Outdated Show resolved Hide resolved
@s00500
Pr fixes
d9c2bde 
- downgrade required go version
- revert modulepath
- fix typo

Signed-off-by: Lukas Bachschwell <lukas@lbsfilm.at>
@s00500
Add Object Identifier Test
fc53e0c 
Signed-off-by: Lukas Bachschwell <lukas@lbsfilm.at>
@s00500
Copy link
Contributor Author

s00500 commented Apr 29, 2024

Adjusted for comments, added test, ready for re-review :-)

@johnweldon johnweldon merged commit 39796f6 into go-asn1-ber:master Apr 30, 2024
9 checks passed
@johnweldon
Copy link
Contributor

Thank you @s00500

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johnweldon johnweldon johnweldon requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@s00500 @johnweldon