This repository has been archived by the owner on Feb 16, 2022. It is now read-only.
Fix JSON encode/decode of lifetime_in_seconds #213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@cyx thanks for the review. Can you please merge? I don't have permission. |
cyx
added a commit
to auth0/auth0-cli
that referenced
this pull request
May 14, 2021
Continuation of #276. Connects to go-auth0/auth0#213
cyx
added a commit
to auth0/auth0-cli
that referenced
this pull request
May 15, 2021
Continuation of #276. Connects to go-auth0/auth0#213
Widcket
pushed a commit
to auth0/auth0-cli
that referenced
this pull request
May 15, 2021
Continuation of #276. Connects to go-auth0/auth0#213
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
The Management API returns a
stringforjwt_configuration.lifetime_in_secondsinstead of anintfor some old tenants.This PR implements a custom JSON marshaler and unmarshaler for
ClientJWTConfigurationthat addresses this.Fixes auth0/auth0-cli#274
Acceptance Test Output
Community Note