Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrading the gherkin cucumber version to v28 #151

Merged
merged 1 commit into from
Apr 29, 2024

Conversation

svandecappelle
Copy link
Contributor

Upgrading the gobdd repository to use to cucumber latest version

If you have any questions don't hesitate.

@bkielbasa
Copy link
Collaborator

thanks @svandecappelle for your contribution. Unfortunately, tests are failing. Could you take a look at it?

Sample failed run: https://github.com/go-bdd/gobdd/actions/runs/8801897807/job/24363828634?pr=151

@svandecappelle
Copy link
Contributor Author

svandecappelle commented Apr 29, 2024

Hello It seems that official repository of gherkin/go only supports >1.17 of golang

Due to uuid v4.4.X breaking change
https://github.com/gofrs/uuid/releases/tag/v4.4.0
NOTE: This release uses Time.UnixMilli() internally which is only available on Go 1.17 or later.

Should not be the time to stop the retro-compat for oldest golang version which is quite old > 5years ?
If we want to keep the support of golang < v1.17 we could not update any dependencies, or migrate to the new official gherkin repository.

@svandecappelle svandecappelle force-pushed the dev/svandeca/gherkin-v28 branch from 3ebbd5f to 0091433 Compare April 29, 2024 09:56
@bkielbasa bkielbasa merged commit 39e9e76 into go-bdd:master Apr 29, 2024
1 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants