recoverer: don't recover http.ErrAbortHandler #624
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pkieltyka
reviewed
Jun 8, 2021
This error is generally used to abort a request while streaming a response so it should not be recovered otherwise the request is not aborted and the client does not detect the error Fixes go-chi#588
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This error is generally used to abort a request while streaming a response
so it should not be recovered otherwise the request is not aborted and
the client does not detect the error.
In my use case I'm streaming a zip file directly to the client (without writing it to the disk). If an error happen while streaming the request body I return
http.ErrAbortHandlerto abort the request without logging a panic. This is the only way to report an error to the client/browser. So this error should not be recovered otherwise the request is not aborted and the client does not detect the error.My use case is quite similar to the one described here