Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

go get cmd/dlv #2

Closed
niemeyer opened this issue Nov 10, 2014 · 1 comment
Closed

go get cmd/dlv #2

niemeyer opened this issue Nov 10, 2014 · 1 comment

Comments

@niemeyer
Copy link

As a suggestion, if you move the main package to .../delve/cmd/dlv, you can replace this:

$ go build -o dlv && mv dlv $GOPATH/bin

by this:

$ go install cmd/dlv

and this would also work to the same effect:

$ go get github.com/derekparker/delve/cmd/dlv

The .../cmd/... path is somewhat conventional, FWIW.
@derekparker
Copy link
Member

That sounds good to me, just made that change. Thanks!

@ataliadvanstep ataliadvanstep mentioned this issue Jun 28, 2017
Closed
derekparker pushed a commit that referenced this issue May 28, 2020
@polinasok
service/dap: Add buildFlags error checking and tests in launch reques…
4be75be 
…ts (#2056)

* service/dap: Add error checking and tests for buildFlags in launch requests

* Clarify with comments and better naming

* Undo redundant support.go changes

* Undo redundant support.go changes (attempt #2)

Co-authored-by: Polina Sokolova <polinasok@users.noreply.github.com>
nclifton pushed a commit to nclifton/delve that referenced this issue Feb 24, 2021
@paran01d
[#175733306] Completed submission code (go-delve#2)
98641be
Foxboron added a commit to Foxboron/delve that referenced this issue Nov 15, 2022
@Foxboron
cmds/command: Include hidden flag -c for coredumpctl support
6e1d5f6 
`coredumpctl` attempts to pass the core file to the debugger through the `-c`
flag. However delve does not support such a flag.

This patch makes it a bool flag so we can receive the coredump file from
`coredumpctl`

    $ GOTRACEBACK=crash ./main
    panic:
    goroutine 1 [running]:
    [....]
    zsh: IOT instruction (core dumped)  GOTRACEBACK=crash ./main
    $ coredumpctl list main
    TIME                            PID  UID  GID SIG     COREFILE EXE                             SIZE
    Tue 2022-11-15 23:29:07 CET 2047401 1000 1000 SIGABRT present  /tmp/go-test/main 60.2K
    $ coredumpctl gdb --debugger=dlv -A core main
               PID: 2047401 (main)
            Signal: 6 (ABRT)
         Timestamp: Tue 2022-11-15 23:29:07 CET (1min 27s ago)
      Command Line: ./main
        Executable: /tmp/go-test/main
         Owner UID: 1000 (fox)
      Size on Disk: 60.2K
           Message: Process 2047401 (main) of user 1000 dumped core.

                    Module /tmp/go-test/main without build-id.
                    Stack trace of thread 2047401:
                    #0  0x000000000045fa01 n/a (/tmp/go-test/main + 0x5fa01)
                    go-delve#1  0x0000000000446d3e n/a (/tmp/go-test/main + 0x46d3e)
                    go-delve#2  0x0000000000445487 n/a (/tmp/go-test/main + 0x45487)
                    go-delve#3  0x000000000045fce6 n/a (/tmp/go-test/main + 0x5fce6)
                    go-delve#4  0x000000000045fde0 n/a (/tmp/go-test/main + 0x5fde0)
                    go-delve#5  0x0000000000432a49 n/a (/tmp/go-test/main + 0x32a49)
                    go-delve#6  0x000000000043211a n/a (/tmp/go-test/main + 0x3211a)
                    go-delve#7  0x000000000048d405 n/a (/tmp/go-test/main + 0x8d405)
                    go-delve#8  0x0000000000434db2 n/a (/tmp/go-test/main + 0x34db2)
                    go-delve#9  0x000000000045e0e1 n/a (/tmp/go-test/main + 0x5e0e1)
                    ELF object binary architecture: AMD x86-64

    [dlv core /tmp/go-test/main -c /var/tmp/coredump-JizL2g]
    Type 'help' for list of commands.
    (dlv) list main.main
    Showing /tmp/go-test/main.go:3 (PC: 0x457c26)
         1:	package main
         2:
         3:	func main() {
         4:		panic()
         5:	}
    (dlv)

Signed-off-by: Morten Linderud <morten@linderud.pw>
Foxboron added a commit to Foxboron/delve that referenced this issue Nov 16, 2022
@Foxboron
cmds/command: Include hidden flag -c for coredumpctl support
a75a8b5 
`coredumpctl` attempts to pass the core file to the debugger through the `-c`
flag. However delve does not support such a flag.

This patch makes it a bool flag so we can receive the coredump file from
`coredumpctl`

    $ GOTRACEBACK=crash ./main
    panic:
    goroutine 1 [running]:
    [....]
    zsh: IOT instruction (core dumped)  GOTRACEBACK=crash ./main
    $ coredumpctl list main
    TIME                            PID  UID  GID SIG     COREFILE EXE                             SIZE
    Tue 2022-11-15 23:29:07 CET 2047401 1000 1000 SIGABRT present  /tmp/go-test/main 60.2K
    $ coredumpctl gdb --debugger=dlv -A core main
               PID: 2047401 (main)
            Signal: 6 (ABRT)
         Timestamp: Tue 2022-11-15 23:29:07 CET (1min 27s ago)
      Command Line: ./main
        Executable: /tmp/go-test/main
         Owner UID: 1000 (fox)
      Size on Disk: 60.2K
           Message: Process 2047401 (main) of user 1000 dumped core.

                    Module /tmp/go-test/main without build-id.
                    Stack trace of thread 2047401:
                    #0  0x000000000045fa01 n/a (/tmp/go-test/main + 0x5fa01)
                    go-delve#1  0x0000000000446d3e n/a (/tmp/go-test/main + 0x46d3e)
                    go-delve#2  0x0000000000445487 n/a (/tmp/go-test/main + 0x45487)
                    go-delve#3  0x000000000045fce6 n/a (/tmp/go-test/main + 0x5fce6)
                    go-delve#4  0x000000000045fde0 n/a (/tmp/go-test/main + 0x5fde0)
                    go-delve#5  0x0000000000432a49 n/a (/tmp/go-test/main + 0x32a49)
                    go-delve#6  0x000000000043211a n/a (/tmp/go-test/main + 0x3211a)
                    go-delve#7  0x000000000048d405 n/a (/tmp/go-test/main + 0x8d405)
                    go-delve#8  0x0000000000434db2 n/a (/tmp/go-test/main + 0x34db2)
                    go-delve#9  0x000000000045e0e1 n/a (/tmp/go-test/main + 0x5e0e1)
                    ELF object binary architecture: AMD x86-64

    [dlv core /tmp/go-test/main -c /var/tmp/coredump-JizL2g]
    Type 'help' for list of commands.
    (dlv) list main.main
    Showing /tmp/go-test/main.go:3 (PC: 0x457c26)
         1:	package main
         2:
         3:	func main() {
         4:		panic()
         5:	}
    (dlv)

Signed-off-by: Morten Linderud <morten@linderud.pw>
aarzilli pushed a commit that referenced this issue Nov 17, 2022
@Foxboron
cmd/dlv: Include hidden flag -c for coredumpctl support (#3195)
2391601 
`coredumpctl` attempts to pass the core file to the debugger through the `-c`
flag. However delve does not support such a flag.

This patch makes it a bool flag so we can receive the coredump file from
`coredumpctl`

    $ GOTRACEBACK=crash ./main
    panic:
    goroutine 1 [running]:
    [....]
    zsh: IOT instruction (core dumped)  GOTRACEBACK=crash ./main
    $ coredumpctl list main
    TIME                            PID  UID  GID SIG     COREFILE EXE                             SIZE
    Tue 2022-11-15 23:29:07 CET 2047401 1000 1000 SIGABRT present  /tmp/go-test/main 60.2K
    $ coredumpctl gdb --debugger=dlv -A core main
               PID: 2047401 (main)
            Signal: 6 (ABRT)
         Timestamp: Tue 2022-11-15 23:29:07 CET (1min 27s ago)
      Command Line: ./main
        Executable: /tmp/go-test/main
         Owner UID: 1000 (fox)
      Size on Disk: 60.2K
           Message: Process 2047401 (main) of user 1000 dumped core.

                    Module /tmp/go-test/main without build-id.
                    Stack trace of thread 2047401:
                    #0  0x000000000045fa01 n/a (/tmp/go-test/main + 0x5fa01)
                    #1  0x0000000000446d3e n/a (/tmp/go-test/main + 0x46d3e)
                    #2  0x0000000000445487 n/a (/tmp/go-test/main + 0x45487)
                    #3  0x000000000045fce6 n/a (/tmp/go-test/main + 0x5fce6)
                    #4  0x000000000045fde0 n/a (/tmp/go-test/main + 0x5fde0)
                    #5  0x0000000000432a49 n/a (/tmp/go-test/main + 0x32a49)
                    #6  0x000000000043211a n/a (/tmp/go-test/main + 0x3211a)
                    #7  0x000000000048d405 n/a (/tmp/go-test/main + 0x8d405)
                    #8  0x0000000000434db2 n/a (/tmp/go-test/main + 0x34db2)
                    #9  0x000000000045e0e1 n/a (/tmp/go-test/main + 0x5e0e1)
                    ELF object binary architecture: AMD x86-64

    [dlv core /tmp/go-test/main -c /var/tmp/coredump-JizL2g]
    Type 'help' for list of commands.
    (dlv) list main.main
    Showing /tmp/go-test/main.go:3 (PC: 0x457c26)
         1:	package main
         2:
         3:	func main() {
         4:		panic()
         5:	}
    (dlv)

Signed-off-by: Morten Linderud <morten@linderud.pw>
alexsaezm pushed a commit to alexsaezm/delve that referenced this issue Nov 23, 2022
@Foxboron @derekparker
cmd/dlv: Include hidden flag -c for coredumpctl support (go-delve#3195)
a701ca9 
`coredumpctl` attempts to pass the core file to the debugger through the `-c`
flag. However delve does not support such a flag.

This patch makes it a bool flag so we can receive the coredump file from
`coredumpctl`

    $ GOTRACEBACK=crash ./main
    panic:
    goroutine 1 [running]:
    [....]
    zsh: IOT instruction (core dumped)  GOTRACEBACK=crash ./main
    $ coredumpctl list main
    TIME                            PID  UID  GID SIG     COREFILE EXE                             SIZE
    Tue 2022-11-15 23:29:07 CET 2047401 1000 1000 SIGABRT present  /tmp/go-test/main 60.2K
    $ coredumpctl gdb --debugger=dlv -A core main
               PID: 2047401 (main)
            Signal: 6 (ABRT)
         Timestamp: Tue 2022-11-15 23:29:07 CET (1min 27s ago)
      Command Line: ./main
        Executable: /tmp/go-test/main
         Owner UID: 1000 (fox)
      Size on Disk: 60.2K
           Message: Process 2047401 (main) of user 1000 dumped core.

                    Module /tmp/go-test/main without build-id.
                    Stack trace of thread 2047401:
                    #0  0x000000000045fa01 n/a (/tmp/go-test/main + 0x5fa01)
                    go-delve#1  0x0000000000446d3e n/a (/tmp/go-test/main + 0x46d3e)
                    go-delve#2  0x0000000000445487 n/a (/tmp/go-test/main + 0x45487)
                    go-delve#3  0x000000000045fce6 n/a (/tmp/go-test/main + 0x5fce6)
                    go-delve#4  0x000000000045fde0 n/a (/tmp/go-test/main + 0x5fde0)
                    go-delve#5  0x0000000000432a49 n/a (/tmp/go-test/main + 0x32a49)
                    go-delve#6  0x000000000043211a n/a (/tmp/go-test/main + 0x3211a)
                    go-delve#7  0x000000000048d405 n/a (/tmp/go-test/main + 0x8d405)
                    go-delve#8  0x0000000000434db2 n/a (/tmp/go-test/main + 0x34db2)
                    go-delve#9  0x000000000045e0e1 n/a (/tmp/go-test/main + 0x5e0e1)
                    ELF object binary architecture: AMD x86-64

    [dlv core /tmp/go-test/main -c /var/tmp/coredump-JizL2g]
    Type 'help' for list of commands.
    (dlv) list main.main
    Showing /tmp/go-test/main.go:3 (PC: 0x457c26)
         1:	package main
         2:
         3:	func main() {
         4:		panic()
         5:	}
    (dlv)

Signed-off-by: Morten Linderud <morten@linderud.pw>
@MariappanBalraj MariappanBalraj mentioned this issue Apr 3, 2023
Open
visualfc pushed a commit to visualfc/delve that referenced this issue Jan 22, 2024
@xushiwei
Merge pull request go-delve#2 from xushiwei/gopdlv
75d0a9c 
// gopdlv: xxx
abner-chenc pushed a commit to loongson/delve that referenced this issue Mar 1, 2024
@polinasok @abner-chenc
service/dap: Add buildFlags error checking and tests in launch reques…
fde5502 
…ts (go-delve#2056)

* service/dap: Add error checking and tests for buildFlags in launch requests

* Clarify with comments and better naming

* Undo redundant support.go changes

* Undo redundant support.go changes (attempt go-delve#2)

Co-authored-by: Polina Sokolova <polinasok@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@niemeyer @derekparker