Add arm-linux support to delve #2122

puppywang · 2020-08-06T19:29:07Z

This is the intial support of arm arch for linux os, to address the problem in this issue #20, The arm-linux's ptrace is lacking support of PTRACE_SINGLESTEP, so we need to emulate it by setup breakpoint at any possible next instructions, and then continue execution. I try to fix all the bug that I found, but there may still have plenty of them. Any code review comments is welcome, thanks.

…tFast.

…42ebac-d125-48c5-afb8-7abd58257c8e/go/GSC-G104

chainhelen · 2020-08-07T03:14:13Z

So great.

…c4c226-cf7f-447a-9173-c59bac0dbc08/go/GSC-G104

aarzilli

How do we test this?

pkg/proc/native/threads_linux_arm.go

pkg/proc/native/threads_single_step_linux.go

pkg/proc/target_exec.go

pkg/proc/native/threads_linux_arm.go

pkg/proc/target_exec.go

…p break instruction on arm. 2. Move breakpointInstr calc outside of for loop.

# Conflicts: # go.sum

aarzilli

In a previous comment I was asking "How do we test this?". This is a question we need to find an answer to. We like to have continuous integration for the architectures we support.

aarzilli · 2020-09-11T06:42:24Z

pkg/proc/native/threads_linux_arm.go

+	nextInstrLen := t.BinInfo().Arch.MaxInstructionLength()
+	nextInstrBytes := make([]byte, nextInstrLen)
+	var err error
+	t.dbp.execPtraceFunc(func() {


Why not just use t.ReadMemory (here and in the other places in this function where PtracePeekData is called)?

As this is inside low level emulation of ptrace singlestep, I want to make sure it first enter the context of ptrace channel, then do the peek and poke work, so I skip the upper Read/WriteMemory function, and use ptrace function directly.

puppywang · 2020-09-15T05:59:00Z

In a previous comment I was asking "How do we test this?". This is a question we need to find an answer to. We like to have continuous integration for the architectures we support.

Yes, currently I do only a little test on raspberry pi4, and I am looking for help to make a more coverage test, do we have any guideline to make such test on different platform? Thanks.

aarzilli · 2020-09-17T16:43:27Z

Yes, currently I do only a little test on raspberry pi4, and I am looking for help to make a more coverage test, do we have any guideline to make such test on different platform? Thanks.

So far we've gotten along using free services like travis, see .travis.yml. It doesn't have 32bit arm but I don't know if it's possible to do the same thing we do with linux/386.

aarzilli · 2020-11-03T11:02:44Z

Regarding testing this, I tried just adding an export GOARCH=arm to the build script. This works on my raspberry pi but it doesn't on Travis-CI, presumably because they didn't enable the appropriate kernel option.
Result of the experiment here: #2218

Additionally the tests hang randomly on my raspberrypi inside native.(*nativeThread).singleStep.

puppywang · 2020-11-05T07:50:18Z

Additionally the tests hang randomly on my raspberrypi inside native.(*nativeThread).singleStep.

Got, let me check with my arm device.

ghost · 2020-11-28T13:41:44Z

Can confirm d75633f works on my Raspberry Pi 3 with an armhf type processor.

daresan · 2020-12-04T13:05:56Z

So no success, to make delve work on a 32bit raspberry Pi OS yet? Just asking, because I just spent more than 2 hours trying to find a 32bit version for raspbian. It should be mentioned in the documentation.

xcaptain · 2021-01-03T17:21:31Z

Also got a raspberry pi and can't run dlv

would take some time to try this branch and see if it works on raspberry pi 4b+

puppywang · 2021-01-06T09:06:31Z

Also got a raspberry pi and can't run dlv

would take some time to try this branch and see if it works on raspberry pi 4b+

Before this merge is accept, you could try my working branch, try following cmd.

git clone https://github.com/puppywang/delve
cd delve
go install
``
And try debug with delve.

krasi-georgiev · 2021-01-20T21:56:23Z

magic I just tested it and it works!

krasi-georgiev · 2021-01-20T22:01:53Z

spoke too soon, stepping in almost never works.

derekparker · 2021-05-18T03:42:41Z

I've been holding off on a deeper review of this since we've never been able to answer the question of how do we have CI for this? I agree 32-bit ARM support would be great, but we need CI to verify this (I don't even have a Pi or other 32-bit ARM system to test this on, unfortunately).

aarzilli · 2021-05-19T06:11:37Z

@derekparker we could probably do the same thing we do on 386 and run it inside docker. If the kernel is compiled with compatibility with arm32 binaries the tests can be run directly on arm64. See my comment #2122 (comment). The problem however is that it randomly hangs inside singleStep.

derekparker · 2021-05-19T17:23:06Z

@derekparker we could probably do the same thing we do on 386 and run it inside docker. If the kernel is compiled with compatibility with arm32 binaries the tests can be run directly on arm64. See my comment #2122 (comment). The problem however is that it randomly hangs inside singleStep.

Ack, alright that makes sense.

@puppywang will you be able to investigate this outstanding issue?

chrisdutz · 2021-06-16T08:18:56Z

Another option I discovered recently would be to use a GitHub Action and to define a "local runner" ... there a RPi could possibly be setup as local runner.

chrisdutz · 2021-06-16T08:26:21Z

And to the cross compiling on a non-arm machine. Was having similar issues with cross compiling some Go application using CGO to 32bit mips and solved that by using a toolchain from the OpenWRT project and setting CC to a gcc version built for building mips. Currently I'm doing the same for an OpenWRT system intended for arm 32bit systems, so this could be used ... however building the OpenWRT toolchain does consume quite a bit of CI-time and might drain the resources an open-source project has available.

krasi-georgiev · 2021-06-16T22:19:26Z

or use the new Balena open fleet :)

https://www.balena.io/blog/introducing-open-fleets-and-self-submitted-apps-and-blocks-on-balenahub/?mc_cid=092773ae21#open-fleets

chrisdutz · 2021-06-17T07:37:34Z

So yesterday I successfully used what we use for building our application for arm32 devices and was able to compile the arm version on my normal ubuntu laptop (So it should be buildable on a normal CI agent or in a Docker container). I was able to run the Delve binary on my edge device, but yes ... I also did encounter these lockups.

Is there anything I can help with?

jochen42 · 2021-09-16T08:04:47Z

i am using a patched dlv-binary (the code of the mr) and go 1.17 on linux-arm7 and remote-debugging. work's like charm until now.
do you plan to integrate this into the stable binanry? Can i support?

aarzilli · 2021-09-16T09:36:21Z

i am using a patched dlv-binary (the code of the mr) and go 1.17 on linux-arm7 and remote-debugging. work's like charm until now.
do you plan to integrate this into the stable binanry? Can i support?

Last time I looked at this it didn't pass most of the tests reliably, so there are no plans at the moment to merge this. If you want to rebase it and fix the problems yourself see: https://github.com/go-delve/delve/blob/master/Documentation/internal/portnotes.md

derekparker · 2022-11-16T17:36:23Z

Closing stale PR.

WangYi added 26 commits August 5, 2020 01:01

[WIP] Add arm support.

9904515

Add ARMArch.

c1fe90f

Add EM_ARM entry in supportedLinuxArch.

30f66c9

Fix printing.

803652b

IP->PC.

49b525d

Fix arch code.

bfa4e24

Tye different approach.

706df9b

Use the sam break instruction as runtime.break.

f1ff9f8

Emulate step.

4d8b6c9

Fix break instruction.

377f9fa

Emulate singlestep.

573bfb7

Use arm64 way to deal with runtime.Breakpoint.

9d3effb

Change back to continue.

31c43c1

Skip runtime.Breakpoint().

4c45c56

Support LDR and ADD as branch instruction.

948d11f

Support POP as return instruction.

b3be60c

Fix instruction classifier in arm_disasm.go and add ADD ret handler.

0b88daf

How silly I am...

d877b52

How silly I am...

3252069

Fix code.

0e8a46d

To be able to catch process exit, we can only use wait instead of wai…

9d78950

…tFast.

More practice to go.

726f771

Use better way to deal with break instruction.

b97a426

Fix panic.

d098f3f

Support LDR.

4bc2ff3

Fix some warning here. https://deepsource.io/gh/go-delve/delve/run/ae…

89a850a

…42ebac-d125-48c5-afb8-7abd58257c8e/go/GSC-G104

Fix some warning here. https://deepsource.io/gh/go-delve/delve/run/c8…

903db7c

…c4c226-cf7f-447a-9173-c59bac0dbc08/go/GSC-G104

aarzilli reviewed Aug 14, 2020

View reviewed changes

pkg/proc/native/threads_linux_arm.go Outdated Show resolved Hide resolved

pkg/proc/native/threads_linux_arm.go Outdated Show resolved Hide resolved

pkg/proc/native/threads_single_step_linux.go Outdated Show resolved Hide resolved

pkg/proc/target_exec.go Outdated Show resolved Hide resolved

Update according to code review.

9a1d76b

aarzilli reviewed Aug 18, 2020

View reviewed changes

pkg/proc/native/threads_linux_arm.go Outdated Show resolved Hide resolved

pkg/proc/target_exec.go Outdated Show resolved Hide resolved

WangYi added 2 commits September 8, 2020 20:56

1. Revert to use BreakInstrMovesPC to determine whether we should ski…

27257ff

…p break instruction on arm. 2. Move breakpointInstr calc outside of for loop.

Merge remote-tracking branch 'origin_1/master' into master

d75633f

# Conflicts: # go.sum

aarzilli reviewed Sep 11, 2020

View reviewed changes

derekparker added arch/arm32 area/proc labels May 19, 2021

derekparker added this to the Unplanned milestone May 19, 2021

adelgado0723 mentioned this pull request Nov 22, 2021

ARM32 support #2051

Open

derekparker closed this Nov 16, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add arm-linux support to delve #2122

Add arm-linux support to delve #2122

puppywang commented Aug 6, 2020

chainhelen commented Aug 7, 2020

aarzilli left a comment

aarzilli left a comment

aarzilli Sep 11, 2020

puppywang Sep 15, 2020

puppywang commented Sep 15, 2020

aarzilli commented Sep 17, 2020

aarzilli commented Nov 3, 2020

puppywang commented Nov 5, 2020 •

edited

Loading

ghost commented Nov 28, 2020

daresan commented Dec 4, 2020

xcaptain commented Jan 3, 2021

puppywang commented Jan 6, 2021 •

edited

Loading

krasi-georgiev commented Jan 20, 2021

krasi-georgiev commented Jan 20, 2021 •

edited

Loading

derekparker commented May 18, 2021

aarzilli commented May 19, 2021

derekparker commented May 19, 2021

chrisdutz commented Jun 16, 2021

chrisdutz commented Jun 16, 2021

krasi-georgiev commented Jun 16, 2021

chrisdutz commented Jun 17, 2021

jochen42 commented Sep 16, 2021

aarzilli commented Sep 16, 2021

derekparker commented Nov 16, 2022

Add arm-linux support to delve #2122

Add arm-linux support to delve #2122

Conversation

puppywang commented Aug 6, 2020

chainhelen commented Aug 7, 2020

aarzilli left a comment

Choose a reason for hiding this comment

aarzilli left a comment

Choose a reason for hiding this comment

aarzilli Sep 11, 2020

Choose a reason for hiding this comment

puppywang Sep 15, 2020

Choose a reason for hiding this comment

puppywang commented Sep 15, 2020

aarzilli commented Sep 17, 2020

aarzilli commented Nov 3, 2020

puppywang commented Nov 5, 2020 • edited Loading

ghost commented Nov 28, 2020

daresan commented Dec 4, 2020

xcaptain commented Jan 3, 2021

puppywang commented Jan 6, 2021 • edited Loading

krasi-georgiev commented Jan 20, 2021

krasi-georgiev commented Jan 20, 2021 • edited Loading

derekparker commented May 18, 2021

aarzilli commented May 19, 2021

derekparker commented May 19, 2021

chrisdutz commented Jun 16, 2021

chrisdutz commented Jun 16, 2021

krasi-georgiev commented Jun 16, 2021

chrisdutz commented Jun 17, 2021

jochen42 commented Sep 16, 2021

aarzilli commented Sep 16, 2021

derekparker commented Nov 16, 2022

puppywang commented Nov 5, 2020 •

edited

Loading

puppywang commented Jan 6, 2021 •

edited

Loading

krasi-georgiev commented Jan 20, 2021 •

edited

Loading