service/dap: send continued event before step response #2594
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Send the continued event before the step response to make sure that there is no time where the client believes that only a single thread is running. Updates golang/vscode-go#1617
polinasok
reviewed
Jul 16, 2021
|
Fixes golang/vscode-go#1629 |
polinasok
approved these changes
Jul 19, 2021
|
@derekparker Are we too late for 1.7.0 release? Vscode rolled out some UI fine tuning that exposed a timing bugs in our adapter that can be pretty annoying and confusing to the users. EDIT: it is too late. 1.7.0 was released already. |
aarzilli
approved these changes
Jul 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Send the continued event before the step response to make sure that there is no time where the client believes that only a single thread is running.
Fixes golang/vscode-go#1629
Updates golang/vscode-go#1617