Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

service/dap,service/debugger: refactor regexp funcs #3348

Merged
merged 1 commit into from
Apr 28, 2023
Merged

service/dap,service/debugger: refactor regexp funcs #3348

merged 1 commit into from
Apr 28, 2023

Conversation

alexandear
Copy link
Contributor

Refactor to use Regexp.MatchString and Regexp.MustCompile.

@alexandear
service/dap,service/debugger: refactor regexp funcs
bed85a9 
Use regex.MatchString and regex.MustCompile.
aarzilli
aarzilli approved these changes Apr 28, 2023
View reviewed changes
Copy link
Member

@aarzilli aarzilli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aarzilli aarzilli merged commit 5f588d8 into go-delve:master Apr 28, 2023
@alexandear alexandear deleted the refactor-regex branch April 29, 2023 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aarzilli aarzilli aarzilli approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alexandear @aarzilli