service/dap: use reloaded value #3349
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The only part of the reloaded value that was used was the Children. This caused a bug where the Time format string was reloaded, but it was not being displayed. Fixes go-delve#3342
|
This is a super minimal change to fix the issue. I think we should probably prioritize reloading in the way described in the TODO above the section. I am planning to take a look at that this afternoon. |
|
|
|
Is this normal on |
Fixing the variable at that level would definitely require additional loading logic. We'd have to check if we need to reload a level earlier to make this work I think so deciding when we need to reload would be the biggest obstacle I believe and the potential performance costs of reloading more aggressively. |
aarzilli
approved these changes
Apr 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The only part of the reloaded value that was used was the Children. This caused a bug where the Time format string was reloaded, but it was not being displayed.
Fixes #3342