Fix PIE tests on ppc64le port #3498
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
derekparker
reviewed
Sep 12, 2023
aarzilli
reviewed
Sep 14, 2023
You're correct, it should but it isn't for this particular sequence. Needs to be fixed upstream. |
|
The ppc64le machine keeps timing out, but the |
If you look at the logs you'll see that a lot of the time is actually spent downloading and installing updates as well as programs we need for the script (jq, gcc, etc). Maybe we should make a docker image that is already up to date and has the things we need installed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PIE tests (tests on binaries built with PIE mode) on ppc64le port were having issues such as not matching expected patterns as in non PIE mode while stepping and not stepping into functions as expected creating errors due to which these tests were skipped on PIE mode
These problems were occurring due to the special prologue emitted on ppc64le to deal with the TOC register or R2
In some cases we had to modify the expected line numbers while stepping
and in some other cases where the breakpoint was set in the prologue instruction even before function entry as a result of which the breakpoint was deemed void and the program control was not entering inside the function we had to modify delve to recognize these patterns to appropriately skip the special prologue and move the breakpoint a few instructions later so that it was set at the right location and the breakpoint was actually hit.
Very soon we will add a change to the Go runtime as well to emit DWARF attributes to recognize such situations so that Delve can recognize this pattern with ease.
For now the current change in Delve fixes the issue and the tests pass.