Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

proc: make some type casts less counterintuitive #3596

Merged
merged 1 commit into from
Dec 12, 2023
Merged

proc: make some type casts less counterintuitive #3596

merged 1 commit into from
Dec 12, 2023

Commits on Dec 11, 2023

  1. proc: make some type casts less counterintuitive 

    The interaction of type casts with load configuration is sometimes
counterintuitive. This commit changes the way it is performed so that
when converting slices to strings and vice versa the maximum size
corresponding to the target type is used (i.e. MaxStringLen when
converting slices to strings and MaxArrayValues when converting slices
to strings).

This doesn't fully solve the problem (conversions to []rune are
problematic and multiple chained type casts will still be confusing)
but removes the problem for the majority of practical uses.

Fixes go-delve#3595, go-delve#3539
    @aarzilli
    aarzilli committed Dec 11, 2023
    Configuration menu
    Copy the full SHA
    71cd664 View commit details
    Browse the repository at this point in the history