Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support range-over-func #3732

Closed
wants to merge 1 commit into from
Closed

Conversation

aarzilli
Copy link
Member

@aarzilli aarzilli commented May 24, 2024

WIP

@aarzilli aarzilli changed the title Support range-over-func [WIP] Support range-over-func May 24, 2024
@aarzilli aarzilli marked this pull request as draft May 24, 2024 10:32
@aarzilli aarzilli force-pushed the rangeoverfunc branch 5 times, most recently from f9f0107 to 5820bb7 Compare May 30, 2024 13:52
@aarzilli aarzilli force-pushed the rangeoverfunc branch 11 times, most recently from 8e75a61 to 3869cc8 Compare June 21, 2024 06:54
@aarzilli aarzilli marked this pull request as ready for review June 21, 2024 17:29
@aarzilli aarzilli changed the title [WIP] Support range-over-func Support range-over-func Jun 21, 2024
@aarzilli aarzilli force-pushed the rangeoverfunc branch 2 times, most recently from 5b4884e to f817a98 Compare June 25, 2024 07:23
@aarzilli aarzilli force-pushed the rangeoverfunc branch 2 times, most recently from d9d957c to d47fe1f Compare July 2, 2024 12:55
Set a breakpoint on the return address of the current function, if it's
a range-over-func body, and clear the stepping breakpoints for the
current function (except the entry one) when its hit.

Without this what can happen is the following:

1. the range-over-func body finishes and returns to the iterator
2. the iterator calls back into the range-over-func body
3. a stepping breakpoint that's inside the prologue gets hit

Updates go-delve#3733
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant