Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

proc: fix bug with stack watchpoints going out of scope #3742

Merged
merged 1 commit into from
Jun 12, 2024

Commits on Jun 7, 2024

  1. proc: fix bug with stack watchpoints going out of scope

    When stack watchpoints go out of scope simultaneously they can hide (or
    duplicate the effect) of other breakpoints (including other watchpoints
    going out of scope) that are placed on the same physical memory
    location.
    
    This happens because we delete the watchpoint-out-of-scope breakpoint
    while we are evaluating hit breakpoints, mangling the breaklets list.
    
    This commit moves breakpoint deletion out of the
    watchpoint-out-of-scope condition, delaying it until all hit
    breakpoints have been evaluated.
    
    Also fix bug where on amd64 if all four watchpoints are in use the last
    one is not checked.
    
    Fixes go-delve#3739
    aarzilli committed Jun 7, 2024
    Configuration menu
    Copy the full SHA
    fd162a6 View commit details
    Browse the repository at this point in the history